Skip to content

Add support for user-events monitoring#520

Merged
dgrove-oss merged 17 commits into
apache:masterfrom
selfxp:user-events
Dec 12, 2019
Merged

Add support for user-events monitoring#520
dgrove-oss merged 17 commits into
apache:masterfrom
selfxp:user-events

Conversation

@selfxp

@selfxp selfxp commented Aug 31, 2019

Copy link
Copy Markdown
Contributor
  • Provides monitoring capabilities for all user specific metrics by deploying user-events, prometheus and grafana on the cluster in case userMetricsEnabled is set to true.

  • It exposes a /monitoring endpoint for accessing the Grafana dashboards.

  • All system metrics will also be stored inside prometheus in case prometheusEnabled=true.

  • More on the user-events service that reads the events from Kafka on this OW PR.

Fixes #519

@dgrove-oss

Copy link
Copy Markdown
Member

This looks great! Took a quick scan; will go through more carefully next week.

TravisCI is failing because the prometheus-server pod is going into a crash loop backoff. Unfortunately the upload of logs from TravisCI to box hasn't been working for a while, so if you can't recreate locally you may need to debug by hacking up the script that runs the test to do some additional kubectl operations to figure out why that pod is sad.

@selfxp

selfxp commented Sep 5, 2019

Copy link
Copy Markdown
Contributor Author

Thx for the tip @dgrove-oss, I was able to reproduce the problem locally. Prometheus deploy should be working fine now with or without persistence.

@dgrove-oss dgrove-oss left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

Left a couple of comments, but none of them are blocking.

Should we hold merging this until the main repo PR is merged (which allows removal of some or all of the adobe-apigateway github references) or merge independent of main repo PR and cleanup later?

Comment thread helm/openwhisk/templates/nginx-cm.yaml
Comment thread helm/openwhisk/values.yaml Outdated

@selfxp selfxp left a comment

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

great, thx @dgrove-oss, yes let's hold of the merge until the user-events has been added to ow main repo, and all adobe references have been updated. Will ping you again when the reviewing process is done.

Comment thread helm/openwhisk/templates/nginx-cm.yaml
Comment thread helm/openwhisk/values.yaml Outdated
@dgrove-oss

Copy link
Copy Markdown
Member

@selfxp -- should we go ahead and merge this now?

@selfxp

selfxp commented Dec 11, 2019

Copy link
Copy Markdown
Contributor Author

@dgrove-oss yes please, it has all the discussed changes in place

@dgrove-oss dgrove-oss merged commit dc889a2 into apache:master Dec 12, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add support for user-events monitoring

2 participants