Skip to content

Accept non-standard status codes.#5149

Merged
rabbah merged 1 commit into
apache:masterfrom
rabbah:webaction-statuscode
Aug 23, 2021
Merged

Accept non-standard status codes.#5149
rabbah merged 1 commit into
apache:masterfrom
rabbah:webaction-statuscode

Conversation

@rabbah

@rabbah rabbah commented Aug 15, 2021 •
edited
Loading

Copy link
Copy Markdown
Member

Description

Related issue and scope

My changes affect the following components

  • API
  • Controller
  • Message Bus (e.g., Kafka)
  • Loadbalancer
  • Scheduler
  • Invoker
  • Intrinsic actions (e.g., sequences, conductors)
  • Data stores (e.g., CouchDB)
  • Tests
  • Deployment
  • CLI
  • General tooling
  • Documentation

Types of changes

  • Bug fix (generally a non-breaking change which closes an issue).
  • Enhancement or new feature (adds new functionality).
  • Breaking change (a bug fix or enhancement which changes existing behavior).

Checklist:

  • I signed an Apache CLA.
  • I reviewed the style guides and followed the recommendations (Travis CI will check :).
  • I added tests to cover my changes.
  • My changes require further changes to the documentation.
  • I updated the documentation where necessary.

@codecov-commenter

codecov-commenter commented Aug 15, 2021 •
edited
Loading

Copy link
Copy Markdown

Codecov Report

Merging #5149 (9f87f15) into master (0cdfdb3) will increase coverage by 30.65%.
The diff coverage is 100.00%.

Impacted file tree graph

@@             Coverage Diff             @@
##           master    #5149       +/-   ##
===========================================
+ Coverage   43.96%   74.62%   +30.65%     
===========================================
  Files         231      231               
  Lines       12807    12804        -3     
  Branches      528      529        +1     
===========================================
+ Hits         5631     9555     +3924     
+ Misses       7176     3249     -3927
Impacted Files Coverage Δ
.../apache/openwhisk/core/controller/WebActions.scala 89.30% <100.00%> (+89.30%) ⬆️
...whisk/connector/kafka/KafkaConsumerConnector.scala 59.15% <0.00%> (-22.54%) ⬇️
...pache/openwhisk/core/invoker/InvokerReactive.scala 58.62% <0.00%> (-20.69%) ⬇️
.../scala/org/apache/openwhisk/utils/Exceptions.scala 20.00% <0.00%> (-20.00%) ⬇️
...whisk/connector/kafka/KafkaProducerConnector.scala 60.00% <0.00%> (-20.00%) ⬇️
.../scala/org/apache/openwhisk/core/WhiskConfig.scala 95.62% <0.00%> (-0.03%) ⬇️
...e/openwhisk/core/containerpool/ContainerPool.scala 96.86% <0.00%> (+1.56%) ⬆️
.../org/apache/openwhisk/core/entity/EntityPath.scala 100.00% <0.00%> (+1.88%) ⬆️
...la/org/apache/openwhisk/common/TransactionId.scala 94.38% <0.00%> (+2.24%) ⬆️
.../org/apache/openwhisk/common/NestedSemaphore.scala 84.84% <0.00%> (+3.03%) ⬆️
... and 128 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0cdfdb3...9f87f15. Read the comment docs.

dgrove-oss
dgrove-oss approved these changes Aug 16, 2021
View reviewed changes

@dgrove-oss dgrove-oss left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@rabbah rabbah merged commit 7e1caaa into apache:master Aug 23, 2021
@rabbah rabbah deleted the webaction-statuscode branch August 23, 2021 01:15
@jaishirole jaishirole mentioned this pull request Aug 23, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@dgrove-oss dgrove-oss dgrove-oss approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@rabbah @codecov-commenter @dgrove-oss