Fix deprecated error#5128
Merged
Merged
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #5128 +/- ##
===========================================
+ Coverage 28.91% 74.60% +45.68%
===========================================
Files 219 233 +14
Lines 11775 12661 +886
Branches 506 521 +15
===========================================
+ Hits 3405 9446 +6041
+ Misses 8370 3215 -5155 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
style95
reviewed
Jun 9, 2021
| docReader: DocumentReader, | ||
| actorSystem: ActorSystem, | ||
| logging: Logging, | ||
| materializer: ActorMaterializer): ArtifactStore[D] = { |
Member
There was a problem hiding this comment.
So we don't need a materializer at all?
ningyougang
reviewed
Jun 9, 2021
| } | ||
|
|
||
| probe.expectMsg(Transition(machine, Paused, Running)) | ||
| pool.expectMsgType[Resumed] |
Contributor
There was a problem hiding this comment.
Great idea for using separate probe object
ningyougang
approved these changes
Jun 9, 2021
style95
approved these changes
Jun 9, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fix deprecated error
Related issue and scope
My changes affect the following components
Types of changes
Checklist: