Skip to content

[New Scheduler] Add container message consumer#5111

Merged
ningyougang merged 3 commits into
apache:masterfrom
upgle:add-container-message-consumer
May 28, 2021
Merged

[New Scheduler] Add container message consumer#5111
ningyougang merged 3 commits into
apache:masterfrom
upgle:add-container-message-consumer

Conversation

@upgle

@upgle upgle commented May 11, 2021

Copy link
Copy Markdown
Member

Description

The container message consumer subscribes to Kafka's containerCreation topic and handles container creation/deletion requests.

The FPCInvokerReactive, which will be newly added, uses this consumer.

Related issue and scope

  • I opened an issue to propose and discuss this change (#????)

My changes affect the following components

  • New scheduler

Types of changes

  • Enhancement or new feature (adds new functionality).
  • Breaking change (a bug fix or enhancement which changes existing behavior).

Checklist:

  • I signed an Apache CLA.
  • I reviewed the style guides and followed the recommendations (Travis CI will check :).
  • I added tests to cover my changes.
  • My changes require further changes to the documentation.
  • I updated the documentation where necessary.

@codecov-commenter

codecov-commenter commented May 11, 2021 •
edited
Loading

Copy link
Copy Markdown

Codecov Report

Merging #5111 (4ee105b) into master (f1829e1) will decrease coverage by 6.17%.
The diff coverage is 59.42%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #5111      +/-   ##
==========================================
- Coverage   81.86%   75.69%   -6.18%     
==========================================
  Files         225      226       +1     
  Lines       11423    11470      +47     
  Branches      501      491      -10     
==========================================
- Hits         9352     8682     -670     
- Misses       2071     2788     +717
Impacted Files Coverage Δ
.../org/apache/openwhisk/core/connector/Message.scala 75.12% <6.25%> (+2.07%) ⬆️
.../scala/org/apache/openwhisk/core/entity/Size.scala 79.10% <50.00%> (ø)
...nwhisk/core/invoker/ContainerMessageConsumer.scala 78.72% <78.72%> (ø)
...core/database/cosmosdb/RxObservableImplicits.scala 0.00% <0.00%> (-100.00%) ⬇️
...ore/database/cosmosdb/cache/CacheInvalidator.scala 0.00% <0.00%> (-100.00%) ⬇️
...e/database/cosmosdb/cache/ChangeFeedConsumer.scala 0.00% <0.00%> (-100.00%) ⬇️
...core/database/cosmosdb/CosmosDBArtifactStore.scala 0.00% <0.00%> (-95.85%) ⬇️
...sk/core/database/cosmosdb/CosmosDBViewMapper.scala 0.00% <0.00%> (-93.90%) ⬇️
...tabase/cosmosdb/cache/CacheInvalidatorConfig.scala 0.00% <0.00%> (-92.31%) ⬇️
...enwhisk/connector/kafka/KamonMetricsReporter.scala 0.00% <0.00%> (-83.34%) ⬇️
... and 22 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f1829e1...4ee105b. Read the comment docs.

@upgle upgle force-pushed the add-container-message-consumer branch from 19f2ef9 to c2ce94b Compare May 26, 2021 01:54
@ningyougang

ningyougang commented May 27, 2021

Copy link
Copy Markdown
Contributor

@upgle , i am sorry, due to test case error and sub prs depend on this pr, i submited a commit for this pr to solve the test case error.

@ningyougang ningyougang merged commit b818c3b into apache:master May 28, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@style95 style95 style95 approved these changes
@ningyougang ningyougang ningyougang approved these changes

Assignees

No one assigned

Labels

scheduler

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@upgle @codecov-commenter @ningyougang @style95