change default nodejs kind from nodejs:10 to nodejs:14#5105
Merged
Conversation
rabbah
approved these changes
Apr 20, 2021
Member
Author
|
Started a dev list discussion as well, since this is a non-trivial change. https://lists.apache.org/thread.html/r95425ad12cabdfbd0552df5768b0b7a260f3311bfe93e925f6d3f57f%40%3Cdev.openwhisk.apache.org%3E |
dgrove-oss
force-pushed
the
nodejs-default
branch
3 times, most recently
from
9a3342c to
3c72fb5
Compare
Codecov Report
@@ Coverage Diff @@
## master #5105 +/- ##
===========================================
+ Coverage 38.79% 75.25% +36.45%
===========================================
Files 218 218
Lines 10700 10700
Branches 454 454
===========================================
+ Hits 4151 8052 +3901
+ Misses 6549 2648 -3901
Continue to review full report at Codecov.
|
dgrove-oss
force-pushed
the
nodejs-default
branch
2 times, most recently
from
99734b9 to
5beea58
Compare
dgrove-oss
force-pushed
the
nodejs-default
branch
from
5beea58 to
4452eee
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Node.js 10 hits its end of life on April 30, 2021. (https://nodejs.org/en/about/releases/)
Prepare for deprecation and eventual removal of the nodejs:10 kind by rolling the default for nodejs forward to nodejs:14 (most recent LTS release).
I propose to skip over nodejs:12 (similar to how we jumped from nodejs:6 to nodejs:10) since the change of a default kind (and associated stemcell change) is marginally disruptive.