[New Scheduler] Add a centralized watcher for etcd data#5069
Merged
Conversation
Codecov Report
@@ Coverage Diff @@
## master #5069 +/- ##
===========================================
- Coverage 81.72% 28.36% -53.37%
===========================================
Files 210 204 -6
Lines 10167 9950 -217
Branches 440 447 +7
===========================================
- Hits 8309 2822 -5487
- Misses 1858 7128 +5270
Continue to review full report at Codecov.
|
style95
reviewed
Feb 19, 2021
| isPrefix: Boolean, | ||
| name: String, | ||
| listenEvents: Set[EtcdEvent] = Set.empty) | ||
| case class UnWatchEndpoint(watchKey: String, isPrefix: Boolean, watchName: String, needFeedback: Boolean = false) |
Member
There was a problem hiding this comment.
Suggested change
| case class UnWatchEndpoint(watchKey: String, isPrefix: Boolean, watchName: String, needFeedback: Boolean = false) | |
| case class UnwatchEndpoint(watchKey: String, isPrefix: Boolean, watchName: String, needFeedback: Boolean = false) |
Contributor
|
LGTM |
ningyougang
approved these changes
Feb 22, 2021
Member
|
Referring to review #5068 (review), you need to add |
Contributor
|
LGTM |
KeonHee
approved these changes
Feb 24, 2021
22 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
The FPC scheduler will use etcd to store and share some data, and some components need to get noticed for some data when they are changed(inserted, updated or removed), this PR implements a centralized watcher for them, which will watch all changes on etcd and distribute them to subscribers
design document: https://cwiki.apache.org/confluence/display/OPENWHISK/WatcherService
Related issue and scope
My changes affect the following components
Types of changes
Checklist: