Codecov Report

Merging #5033 (62c62af) into master (4babe39) will decrease coverage by 47.81%.
The diff coverage is n/a.

@@             Coverage Diff             @@
##           master    #5033       +/-   ##
===========================================
- Coverage   83.77%   35.96%   -47.82%     
===========================================
  Files         202      202               
  Lines        9818     9818               
  Branches      416      416               
===========================================
- Hits         8225     3531     -4694     
- Misses       1593     6287     +4694     

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4babe39...62c62af. Read the comment docs.

It seems flake8 is failed to run.

Flake8: first round (fast fail) stops the build if there are any Python 3 syntax errors...
Traceback (most recent call last):
  File "/home/travis/.local/bin/flake8", line 7, in <module>
    from flake8.main.cli import main
  File "/home/travis/.local/lib/python3.5/site-packages/flake8/main/cli.py", line 5, in <module>
    from flake8.main import application
  File "/home/travis/.local/lib/python3.5/site-packages/flake8/main/application.py", line 11, in <module>
    from flake8 import checker
  File "/home/travis/.local/lib/python3.5/site-packages/flake8/checker.py", line 18, in <module>
    from flake8 import processor
  File "/home/travis/.local/lib/python3.5/site-packages/flake8/processor.py", line 13, in <module>
    from flake8 import utils
  File "/home/travis/.local/lib/python3.5/site-packages/flake8/utils.py", line 16, in <module>
    from flake8._compat import lru_cache
  File "/home/travis/.local/lib/python3.5/site-packages/flake8/_compat.py", line 12, in <module>
    import importlib_metadata
  File "/home/travis/.local/lib/python3.5/site-packages/importlib_metadata/__init__.py", line 43, in <module>
    class PackageNotFoundError(ModuleNotFoundError):
NameError: name 'ModuleNotFoundError' is not defined

importlib_metadata has changed to submodule(importlib.metadata) since python3.8 and I suspect there are some issues in the flake8 though we are using python3.5 in Travis.

I think we can try to use python3.8 to clarify the issue.

trying newer python makes sense. More generally, we are requesting xenial (16.04) as our ubuntu in travis. We should probably move to 18.04 or 20.04.

@jiangpengcheng Could you open a new PR to upgrade python and underlying ubuntu version by replicating this PR to update the Travis info as well?
We can see if that fixes the issue.

ok

@jiangpengcheng Would it be ok for me to work on this issue in parallel as this is the main bottleneck for now?

@style95 sure

folded into #5042

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 35.96%. Comparing base (4babe39) to head (62c62af).
Report is 250 commits behind head on master.

❗ There is a different number of reports uploaded between BASE (4babe39) and HEAD (62c62af). Click for more details.

HEAD has 79 uploads less than BASE

Flag	BASE (4babe39)	HEAD (62c62af)
	82	3

@@             Coverage Diff             @@
##           master    #5033       +/-   ##
===========================================
- Coverage   83.81%   35.96%   -47.86%     
===========================================
  Files         202      202               
  Lines        9818     9818               
  Branches      416      416               
===========================================
- Hits         8229     3531     -4698     
- Misses       1589     6287     +4698     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.