[New Scheduler] Implement FCPSchedulerServer#5030
Merged
Merged
Conversation
b2578f8 to
100d1ce
Compare
bdoyle0182
reviewed
Nov 20, 2020
| logger.warn(this, "Scheduler is disabled") | ||
| scheduler.disable() | ||
| complete("scheduler disabled") | ||
| } ~ (path("queue" / "total") & get) { |
Contributor
There was a problem hiding this comment.
let's put queue in a constant as it will likely be reused as new api's are added
Contributor
Author
There was a problem hiding this comment.
Updated accordingly, thanks for your review!
Codecov Report
@@ Coverage Diff @@
## master #5030 +/- ##
==========================================
- Coverage 82.10% 75.75% -6.35%
==========================================
Files 200 207 +7
Lines 9760 10034 +274
Branches 447 444 -3
==========================================
- Hits 8013 7601 -412
- Misses 1747 2433 +686
Continue to review full report at Codecov.
|
100d1ce to
5dd6065
Compare
Contributor
|
LGTM |
bdoyle0182
approved these changes
Dec 9, 2020
5dd6065 to
6c82d6e
Compare
6c82d6e to
850ae67
Compare
Contributor
Author
|
Have any comment? |
Member
|
I think @bdoyle0182 already approved this PR and it has been so long so we can merge this if it passes all CI tests. |
850ae67 to
0b292bf
Compare
0b292bf to
a8a1f83
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This is the document for new Scheduler: https://cwiki.apache.org/confluence/display/OPENWHISK/New+architecture+proposal
Regarding FPCSchedulerServer, it provides some APIs to access the concrete info for scheduler node. including
When want to gracefully shutdown the scheduler, can invoke /disable
Related issue and scope
My changes affect the following components
Types of changes
Checklist: