Skip to content

Add swift:5.1 kind to runtimes.json#4803

Merged
rabbah merged 2 commits into
apache:masterfrom
dgrove-oss:swift5
Jan 24, 2020
Merged

Add swift:5.1 kind to runtimes.json#4803
rabbah merged 2 commits into
apache:masterfrom
dgrove-oss:swift5

Conversation

@dgrove-oss

@dgrove-oss dgrove-oss commented Jan 21, 2020

Copy link
Copy Markdown
Member

No description provided.

@codecov-io

codecov-io commented Jan 21, 2020

Copy link
Copy Markdown

Codecov Report

Merging #4803 into master will decrease coverage by 6.59%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##           master    #4803     +/-   ##
=========================================
- Coverage   85.19%   78.59%   -6.6%     
=========================================
  Files         197      197             
  Lines        8839     8839             
  Branches      619      619             
=========================================
- Hits         7530     6947    -583     
- Misses       1309     1892    +583
Impacted Files Coverage Δ
...core/database/cosmosdb/RxObservableImplicits.scala 0% <0%> (-100%) ⬇️
...enwhisk/connector/kafka/KamonMetricsReporter.scala 0% <0%> (-100%) ⬇️
...e/database/cosmosdb/cache/ChangeFeedConsumer.scala 0% <0%> (-100%) ⬇️
...ore/database/cosmosdb/cache/CacheInvalidator.scala 0% <0%> (-100%) ⬇️
...core/database/cosmosdb/CosmosDBArtifactStore.scala 0% <0%> (-96.23%) ⬇️
...sk/core/database/cosmosdb/CosmosDBViewMapper.scala 0% <0%> (-93.85%) ⬇️
...tabase/cosmosdb/cache/CacheInvalidatorConfig.scala 0% <0%> (-92.31%) ⬇️
...e/database/cosmosdb/cache/KafkaEventProducer.scala 0% <0%> (-77.78%) ⬇️
...whisk/core/database/cosmosdb/CosmosDBSupport.scala 0% <0%> (-74.08%) ⬇️
...abase/cosmosdb/CosmosDBArtifactStoreProvider.scala 7.69% <0%> (-50%) ⬇️
... and 8 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 51de9d7...f9a2950. Read the comment docs.

@dgrove-oss dgrove-oss requested a review from rabbah January 24, 2020 15:07
@rabbah

rabbah commented Jan 24, 2020

Copy link
Copy Markdown
Member

Should update the swagger too - will add link.

@rabbah

rabbah commented Jan 24, 2020

Copy link
Copy Markdown
Member

https://github.com/apache/openwhisk/blob/master/core/controller/src/main/resources/apiv1swagger.json

@dgrove-oss

dgrove-oss commented Jan 24, 2020

Copy link
Copy Markdown
Member Author

Thanks. updated swagger for both Swift 5.1 and .NET 3.1 (was missed when we added .NET 3.1)

@rabbah rabbah merged commit fcbe9ca into apache:master Jan 24, 2020
@dgrove-oss dgrove-oss deleted the swift5 branch January 24, 2020 22:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@rabbah rabbah rabbah approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@dgrove-oss @codecov-io @rabbah