Feature flag support to turn on/off support for provide-api-key annotation#4334
Conversation
| */ | ||
| protected[core] def amendAnnotations(annotations: Parameters, exec: Exec, create: Boolean = true): Parameters = { | ||
| val newAnnotations = if (create) { | ||
| val newAnnotations = if (create && FeatureFlags.requireApiKeyAnnotation) { |
There was a problem hiding this comment.
i suspect that if this is set to false, some tests will fail.
did you consider also updating this for completeness although there may be another place or two that don't use this method that could be affected.
There was a problem hiding this comment.
For now I do not think that we should make test case complex with feature flag support. So test should work assuming all new features enabled (unless using some SPI mechanism). For main code we just validate manually that if feature is disabled then we get back the earlier behavior.
|
This looks great :-). Exactly what I was thinking about. Many thanks for providing this implementation. For me this is a good example and I will take some time and look at the code to understand how it has been implemented. 👍 |
3 participants
Enables support for feature flags which for now is used to enable or disable support for
provide-api-key(#4284)Description
With #4284 support was added for
provide-api-keyannotation. In some cases we may want to enable this feature later. This PR introduces a feature flag support which allow disabling such feature based on config. To disable this feature use config like belowRelated issue and scope
My changes affect the following components
Types of changes
Checklist: