tools/dev - updated intellij script to start controller and invoker locally#4142
Merged
Conversation
ddragosd
added
the
review
chetanmeh
approved these changes
Nov 30, 2018
chetanmeh
left a comment
chetanmeh
left a comment
Member
There was a problem hiding this comment.
This would simplify debugging some of the Invoker related flows in IDE. Some minor changes otherwise good to go
tysonnorris
reviewed
Dec 2, 2018
tysonnorris
reviewed
Dec 2, 2018
tysonnorris
reviewed
Dec 2, 2018
tysonnorris
reviewed
Dec 2, 2018
tysonnorris
reviewed
Dec 2, 2018
ddragosd
changed the title
Codecov Report
@@ Coverage Diff @@
## master #4142 +/- ##
==========================================
+ Coverage 77.91% 80.82% +2.91%
==========================================
Files 151 152 +1
Lines 7277 7391 +114
Branches 468 473 +5
==========================================
+ Hits 5670 5974 +304
+ Misses 1607 1417 -190
Continue to review full report at Codecov.
|
BillZong
pushed a commit
to BillZong/openwhisk
that referenced
this pull request
Nov 18, 2019
…ocally (apache#4142) * tools/dev - updated intellij script for docker-compose * Added support for docker for mac * log-limit is 0 to avoid collection logs * updates for wskdev with ansible
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR updates
gradlew :tools:dev:intellijto work with docker-compose and ansible locally . It basically makes the generation of IntelliJ configuration a bit more generic.In addition, it adds a container factory for Mac, to expose action container ports on the host, as otherwise the invoker can't make HTTP requests to the action containers. Docker for Mac doesn't expose any direct route to containers.
My changes affect the following components
Types of changes
Checklist: