Add nodejs:10 to default set of runtimes for ansible/vagrant#4124
Merged
Conversation
dgrove-oss
approved these changes
Nov 19, 2018
dgrove-oss
left a comment
dgrove-oss
left a comment
Member
There was a problem hiding this comment.
Looks good except for the one typo noted above.
| The CLI automatically infers the type of the action by using the source file extension. | ||
| For `.js` source files, the action runs by using a Node.js runtime. You may specify | ||
| the Node.js runtime to use by explicitly specifying the parameter `--kind nodejs:6` or `--kind nodejs:8`. | ||
| the Node.js runtime to use by explicitly specifying the parameter `--kind nodejs:10`, `--kind nodejs:8`, or `--kind nodejs:10` |
Member
There was a problem hiding this comment.
typo? has :10 twice, but missing :6.
csantanapr
changed the title
Codecov Report
@@ Coverage Diff @@
## master #4124 +/- ##
==========================================
- Coverage 86.16% 81.28% -4.88%
==========================================
Files 151 151
Lines 7263 7263
Branches 466 466
==========================================
- Hits 6258 5904 -354
- Misses 1005 1359 +354
Continue to review full report at Codecov.
|
BillZong
pushed a commit
to BillZong/openwhisk
that referenced
this pull request
Nov 18, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Add nodejs:10 to default set of runtimes
Related issue and scope
My changes affect the following components
Types of changes
Checklist: