Remove 'kinds' from CLI; defer to backend.#2053
Merged
Merged
Conversation
rabbah
added
cli
review
rabbah
force-pushed
the
exec-manifest-cli
branch
from
eab40f1 to
950e318
Compare
Member
Author
|
pg2/1265 🔵 |
Member
|
@dubeejw could put some 👀 on this when you have a chance |
dubee
requested changes
Mar 21, 2017
| actionUpdateCmd.Flags().BoolVar(&flags.action.copy, "copy", false, wski18n.T("treat ACTION as the name of an existing action")) | ||
| actionUpdateCmd.Flags().BoolVar(&flags.action.sequence, "sequence", false, wski18n.T("treat ACTION as comma separated sequence of actions to invoke")) | ||
| actionUpdateCmd.Flags().StringVar(&flags.action.kind, "kind", "", wski18n.T("the `KIND` of the action runtime (example: swift:3, nodejs:6)")) | ||
| actionUpdateCmd.Flags().StringVar(&flags.action.kind, "kind", "", wski18n.T("the `KIND` of the action runtime (example: swift:default, nodejs:default)")) |
Member
There was a problem hiding this comment.
You will need to update the file containing externalized strings for this change. See tools/cli/go-whisk-cli/wski18n/resources/en_US.all.json.
| actionCreateCmd.Flags().BoolVar(&flags.action.copy, "copy", false, wski18n.T("treat ACTION as the name of an existing action")) | ||
| actionCreateCmd.Flags().BoolVar(&flags.action.sequence, "sequence", false, wski18n.T("treat ACTION as comma separated sequence of actions to invoke")) | ||
| actionCreateCmd.Flags().StringVar(&flags.action.kind, "kind", "", wski18n.T("the `KIND` of the action runtime (example: swift:3, nodejs:6)")) | ||
| actionCreateCmd.Flags().StringVar(&flags.action.kind, "kind", "", wski18n.T("the `KIND` of the action runtime (example: swift:default, nodejs:default)")) |
Member
There was a problem hiding this comment.
See comment about externalized strings.
| action.Exec.Kind = "nodejs" | ||
| } else if flags.action.kind == "python" { | ||
| action.Exec.Kind = "python" | ||
| if len(flags.action.kind) > 0 { |
Member
There was a problem hiding this comment.
If a user enters a --kind value that is not supported, will the backend return an error when the request is sent for processing? If so, is there a test?
It would be fantastic if you can create a function that handles all the --kind processing and reference that in parseAction().
Member
Author
There was a problem hiding this comment.
Yes it will:
> wsk action create foo t.js --kind foobar
error: Unable to create action: The request content was malformed:
kind 'foobar' not in Set(swift:3, nodejs, blackbox, java, sequence, nodejs:6, python, swift) (code 1206)
Run 'wsk --help' for usage.
I don't understand the second part of the comment re parseAction.
Member
Member
There was a problem hiding this comment.
Essentially I wanted this action.Exec, err = getExec(args[1]) to reduce the amount of code in parseAction.
Member
There was a problem hiding this comment.
Just to be safe, you may also want to pass flags.action.kind, and flags.action.docker to the new method since those are globals and could be accidentally be overwritten. Ex: getExec(args[1], flags.action.kind, flags.action.docker)
Member
Author
There was a problem hiding this comment.
thanks for the explanation and pr.
Member
Author
There was a problem hiding this comment.
OK to stage the refactoring to a separate pr so that we can enable python 3?
Member
There was a problem hiding this comment.
It can be done later if necessary.
rabbah
force-pushed
the
exec-manifest-cli
branch
from
176299e to
02d18b4
Compare
Member
|
@csantanapr, LGTM! |
Member
Author
|
I'll re pg. |
rabbah
force-pushed
the
exec-manifest-cli
branch
from
31b6f40 to
69b6b5f
Compare
rabbah
force-pushed
the
exec-manifest-cli
branch
from
60a278d to
d240ce3
Compare
Member
Author
|
pg4/93 good to merge. |
Member
|
@dubeejw can you approve the review record if it still Looks good to you? |
Member
|
I think it's good to merge. I don't have write access to officially approve :). |
Member
|
@dubeejw You don't need write access to officially approve, you see a green button on this page |
dubee
approved these changes
Mar 24, 2017
csantanapr
approved these changes
Mar 24, 2017
houshengbo
pushed a commit
to houshengbo/openwhisk
that referenced
this pull request
Jun 23, 2017
* Remove 'kinds' from CLI; defer to backend. * Fix messages. * Add cli test for unknown kind. * Move Kind Process to its Own Method to Declutter ParseAction (apache#9) * pass flags to getExec.
houshengbo
pushed a commit
to houshengbo/openwhisk
that referenced
this pull request
Jun 23, 2017
* Remove 'kinds' from CLI; defer to backend. * Fix messages. * Add cli test for unknown kind. * Move Kind Process to its Own Method to Declutter ParseAction (apache#9) * pass flags to getExec.
houshengbo
pushed a commit
to houshengbo/openwhisk
that referenced
this pull request
Jun 23, 2017
* Remove 'kinds' from CLI; defer to backend. * Fix messages. * Add cli test for unknown kind. * Move Kind Process to its Own Method to Declutter ParseAction (apache#9) * pass flags to getExec.
houshengbo
pushed a commit
to houshengbo/openwhisk
that referenced
this pull request
Jul 17, 2017
* Remove 'kinds' from CLI; defer to backend. * Fix messages. * Add cli test for unknown kind. * Move Kind Process to its Own Method to Declutter ParseAction (apache#9) * pass flags to getExec.
houshengbo
pushed a commit
to houshengbo/openwhisk
that referenced
this pull request
Jul 21, 2017
* Remove 'kinds' from CLI; defer to backend. * Fix messages. * Add cli test for unknown kind. * Move Kind Process to its Own Method to Declutter ParseAction (apache#9) * pass flags to getExec.
houshengbo
pushed a commit
to houshengbo/openwhisk
that referenced
this pull request
Jul 21, 2017
* Remove 'kinds' from CLI; defer to backend. * Fix messages. * Add cli test for unknown kind. * Move Kind Process to its Own Method to Declutter ParseAction (apache#9) * pass flags to getExec.
houshengbo
pushed a commit
to houshengbo/openwhisk
that referenced
this pull request
Nov 13, 2017
* Remove 'kinds' from CLI; defer to backend. * Fix messages. * Add cli test for unknown kind. * Move Kind Process to its Own Method to Declutter ParseAction (apache#9) * pass flags to getExec.
houshengbo
pushed a commit
to houshengbo/openwhisk
that referenced
this pull request
Nov 13, 2017
* Remove 'kinds' from CLI; defer to backend. * Fix messages. * Add cli test for unknown kind. * Move Kind Process to its Own Method to Declutter ParseAction (apache#9) * pass flags to getExec.
houshengbo
pushed a commit
to houshengbo/openwhisk
that referenced
this pull request
Nov 13, 2017
* Remove 'kinds' from CLI; defer to backend. * Fix messages. * Add cli test for unknown kind. * Move Kind Process to its Own Method to Declutter ParseAction (apache#9) * pass flags to getExec.
houshengbo
pushed a commit
to houshengbo/openwhisk
that referenced
this pull request
Nov 13, 2017
* Remove 'kinds' from CLI; defer to backend. * Fix messages. * Add cli test for unknown kind. * Move Kind Process to its Own Method to Declutter ParseAction (apache#9) * pass flags to getExec.
houshengbo
pushed a commit
to houshengbo/openwhisk
that referenced
this pull request
Nov 14, 2017
* Remove 'kinds' from CLI; defer to backend. * Fix messages. * Add cli test for unknown kind. * Move Kind Process to its Own Method to Declutter ParseAction (apache#9) * pass flags to getExec.
houshengbo
pushed a commit
to houshengbo/openwhisk
that referenced
this pull request
Nov 14, 2017
* Remove 'kinds' from CLI; defer to backend. * Fix messages. * Add cli test for unknown kind. * Move Kind Process to its Own Method to Declutter ParseAction (apache#9) * pass flags to getExec.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR is to permit progress on adding python:3 support.
Further CLI enhancements related to kind-awareness planned for/after #1980; in particular
wsk property getto list supported kinds for deployment.FYI @cclauss.