Remove IoTConsensus auto leader balance toggle#17950
Merged
Merged
Conversation
CRZbulabula
force-pushed
the
fix-region-allocation-it-timeout
branch
from
39f89f5 to
dc4493b
Compare
CRZbulabula
changed the title
|
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #17950 +/- ##
============================================
- Coverage 41.15% 41.15% -0.01%
Complexity 318 318
============================================
Files 5258 5258
Lines 365613 365602 -11
Branches 47282 47279 -3
============================================
- Hits 150460 150451 -9
+ Misses 215153 215151 -2 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
JackieTien97
approved these changes
Jun 16, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Remove the
enable_auto_leader_balance_for_iot_consensusconfiguration option and its test-environment setter APIs.IoTConsensus and IoTConsensusV2 RegionGroups now always participate in ConfigNode leader balancing. This matches the previous default behavior and avoids the invalid opt-out case where newly created IoTConsensus RegionGroups could remain with
leaderId=-1untilCreateRegionGroupsProcedurewaited close to the procedure timeout. In the per-database allocation IT, that could surface asCREATE_REGION_ERRORunder the GCR policy even though all replicas had been created successfully.The Ratis auto leader balance toggle is left unchanged.
This patch also keeps the DataPartition creation assertion in
IoTDBPerDatabaseRegionGroupAllocationITmore diagnostic by including the returned TSStatus in the failure message.Tests
mvn spotless:apply -pl iotdb-core/confignode,iotdb-core/node-commons,integration-test -P with-integration-testsmvn verify -Drat.skip=true -DskipUTs -Dit.test=IoTDBPerDatabaseRegionGroupAllocationIT,IoTDBRegionGroupLeaderDistributionIT,IoTDBMultiDBRegionGroupLeaderDistributionIT -DfailIfNoTests=false -Dfailsafe.failIfNoSpecifiedTests=false -pl integration-test -am -PClusterIT -P with-integration-testsNote: local full RAT validation is blocked by an unrelated
.claude/scheduled_tasks.lockfile in the working tree, so the focused IT verification used-Drat.skip=true.