fix(catalog/rest): do not leak response bodies #655
Merged
+87
−2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In error case, body isn't closed so underlying TCP connection might not be used. Defer closing and draining unconditionally for safer and more idiomatic handling. Signed-off-by: ferhat elmas <[email protected]>
zeroshade
reviewed
Dec 22, 2025
| return ret, err | ||
| } | ||
| defer func() { | ||
| _, _ = io.Copy(io.Discard, rsp.Body) |
Member
There was a problem hiding this comment.
is this actually necessary? Isn't rsp.Body.Close() sufficient?
Contributor
Author
There was a problem hiding this comment.
no it should be consumed per https://pkg.go.dev/net/http#Response
// It is the caller's responsibility to
// close Body. The default HTTP client's Transport may not
// reuse HTTP/1.x "keep-alive" TCP connections if the Body is
// not read to completion and closed.
zeroshade
approved these changes
Dec 23, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In error case, body isn't closed so
underlying TCP connection might not be used.
Defer closing and draining unconditionally
for safer and more idiomatic handling.