-
Notifications
You must be signed in to change notification settings - Fork 26.6k
Fixed flaky test: org.apache.dubbo.common.bytecode.WrapperTest.est_getMethodNames_ContainExtendsParentMethods #15683
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## 3.3 #15683 +/- ##
============================================
- Coverage 61.01% 61.00% -0.01%
+ Complexity 11698 11692 -6
============================================
Files 1923 1923
Lines 87069 87069
Branches 13112 13112
============================================
- Hits 53124 53116 -8
- Misses 28495 28500 +5
- Partials 5450 5453 +3
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
zrlw
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
oxsean
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM.
What is the purpose of this PR
org.apache.dubbo.common.bytecode.WrapperTest.est_getMethodNames_ContainExtendsParentMethods.getMethodNamesmethods fromWrapperandClassUtilsclasses.Why the test fail
assertArrayEqualsexpects even the order of the array elements to match - hence sometimes causing the failure.How to reproduce the test failure
The scenario may be reproduced by running the tests with Nondex tool:
Instructions on Nondex installation may be found here.
Expected results
The test should run successfully with Nondex instrumentation.
Actual Results
[ERROR] Failed to execute goal edu.illinois:nondex-maven-plugin:2.1.7:nondex (default-cli) on project dubbo-common: Unable to execute mojo: There are test failures.[ERROR] WrapperTest.test_getMethodNames_ContainExtendsParentMethods:184 array contents differ at index [0], expected: <hello> but was: <world>Description of fix
sortmethod ofjava.utilas inArrays.sort(methodNames).