Skip to content

[3.3] Add http2 server connection preface process #15535

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
zrlw merged 2 commits into from
Jul 20, 2025
Merged

[3.3] Add http2 server connection preface process #15535

zrlw merged 2 commits into from
Jul 20, 2025

Conversation

@zrlw
Copy link
Contributor

@zrlw zrlw commented Jul 10, 2025 •
edited
Loading

What is the purpose of the change?

HTTP/2 server should wait for connection preface before sending first http2 data frame to client, otherwise it might also encounter the similar issue like #15460
af0ce318e90deb46a33f21fe59b00ee8
The client posts a HTTP/1 request with h2c upgrade contents, but the server does not wait for the http2 settings frame before sending response.
7d4b50b7d544137e64fc1f019cd26df

Checklist

  • Make sure there is a GitHub_issue field for the change.
  • Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
  • Write necessary unit-test to verify your logic correction. If the new feature or significant change is committed, please remember to add sample in dubbo samples project.
  • Make sure gitHub actions can pass. Why the workflow is failing and how to fix it?

@zrlw zrlw force-pushed the 3.3-fixed-waitClientHttp2SettingsFrame branch from e3ffe76 to 01001a8 Compare July 10, 2025 11:01
@codecov-commenter
Copy link

codecov-commenter commented Jul 10, 2025 •
edited
Loading

Codecov Report

Attention: Patch coverage is 36.70886% with 50 lines in your changes missing coverage. Please review.

Project coverage is 60.82%. Comparing base (b5fca6f) to head (d1132d5).

Files with missing lines Patch % Lines
...emoting/http12/netty4/h2/NettyHttp2FrameCodec.java 21.56% 37 Missing and 3 partials ⚠️
...ng/http12/netty4/h2/NettyHttp2SettingsHandler.java 57.89% 6 Missing and 2 partials ⚠️
...he/dubbo/rpc/protocol/tri/TripleHttp2Protocol.java 66.66% 2 Missing ⚠️
Additional details and impacted files 
@@             Coverage Diff              @@
##                3.3   #15535      +/-   ##
============================================
- Coverage     60.87%   60.82%   -0.06%     
- Complexity       12    11433   +11421     
============================================
  Files          1908     1909       +1     
  Lines         86693    86761      +68     
  Branches      12997    13009      +12     
============================================
- Hits          52775    52771       -4     
- Misses        28462    28532      +70     
- Partials       5456     5458       +2
Flag Coverage Δ
integration-tests-java17 32.95% <30.37%> (-0.06%) ⬇️
integration-tests-java8 33.10% <30.37%> (+0.03%) ⬆️
samples-tests-java17 31.34% <3.79%> (-0.04%) ⬇️
samples-tests-java8 29.25% <1.26%> (+0.02%) ⬆️
unit-tests 58.74% <34.17%> (-0.09%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@zrlw zrlw force-pushed the 3.3-fixed-waitClientHttp2SettingsFrame branch 13 times, most recently from d9bcbe3 to 6810350 Compare July 11, 2025 07:22
@zrlw zrlw force-pushed the 3.3-fixed-waitClientHttp2SettingsFrame branch 3 times, most recently from 9d23941 to 5e35cfa Compare July 12, 2025 08:47
@zrlw zrlw force-pushed the 3.3-fixed-waitClientHttp2SettingsFrame branch from 5e35cfa to d1132d5 Compare July 12, 2025 09:02
@zrlw zrlw merged commit d079dec into apache:3.3 Jul 20, 2025
29 checks passed
@zrlw zrlw deleted the 3.3-fixed-waitClientHttp2SettingsFrame branch July 20, 2025 03:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@zrlw @codecov-commenter