PYTHON-1328: Add explicit wait to give cluster time to get initialized#1139
Merged
absurdfarce merged 2 commits intomasterfrom Mar 9, 2023
Merged
PYTHON-1328: Add explicit wait to give cluster time to get initialized#1139absurdfarce merged 2 commits intomasterfrom
absurdfarce merged 2 commits intomasterfrom
Conversation
absurdfarce
commented
Mar 8, 2023
| # | ||
| # Give the cluster enough time to startup (and perform necessary initialization) | ||
| # before executing the test. | ||
| if CASSANDRA_VERSION > Version('4.0-a'): |
Contributor
Author
There was a problem hiding this comment.
Version string here pulled from the annotations defined in tests/integration/__init__.py
absurdfarce
commented
Mar 8, 2023
| # Give the cluster enough time to startup (and perform necessary initialization) | ||
| # before executing the test. | ||
| if CASSANDRA_VERSION > Version('4.0-a'): | ||
| time.sleep(10) |
Contributor
Author
There was a problem hiding this comment.
This wait was happening within a test method but this relies on tests being executed in a specific order which is... not great. Moving to module initialization logic should resolve that issue.
Lorak-mmk
added a commit
to Lorak-mmk/python-driver
that referenced
this pull request
Mar 31, 2023
version 3.26.0 * tag '3.26.0' of https://github.com/datastax/python-driver: (22 commits) Release 3.26: changelog & version Going back to known good non-2.7 PyPy target. PYTHON-1333 has more detail. Forgot to add complete extension Trying to get to a maximal working Pypy version. Have to go back to 3.6 which isn't ideal... Update Travis config to only run versions that will be supported going forward Minor refactor of prior commit: now that we're dropping 2.7.x support we don't really need to leverage six for unit test functions. Remove references to unsupported Python versions from setup.py Refactor deprecated unittest aliases for Python 3.11 compatibility. (apache#1112) Merge pull request apache#1140 from python-driver/python-1327 Merge pull request apache#1139 from python-driver/python-1328 Merge pull request apache#1137 from python-driver/python-1329 Merge pull request apache#1128 from python-driver/python-1304 Fix jenkins builds (apache#1134) Minor refactor of prior commit Handle "log gone" case in the end of _run_loop (apache#1133) HostFilterPolicyInitTest fix for Python 3.11 (apache#1131) Groovy fixes Hey, let's actually update the right things, shall we? Smaller smoke test configuration to avoid explosion of test builds in AWS Fix to prior fix ...
Lorak-mmk
added a commit
to Lorak-mmk/python-driver
that referenced
this pull request
Apr 12, 2023
version 3.26.0 * tag '3.26.0' of https://github.com/datastax/python-driver: (22 commits) Release 3.26: changelog & version Going back to known good non-2.7 PyPy target. PYTHON-1333 has more detail. Forgot to add complete extension Trying to get to a maximal working Pypy version. Have to go back to 3.6 which isn't ideal... Update Travis config to only run versions that will be supported going forward Minor refactor of prior commit: now that we're dropping 2.7.x support we don't really need to leverage six for unit test functions. Remove references to unsupported Python versions from setup.py Refactor deprecated unittest aliases for Python 3.11 compatibility. (apache#1112) Merge pull request apache#1140 from python-driver/python-1327 Merge pull request apache#1139 from python-driver/python-1328 Merge pull request apache#1137 from python-driver/python-1329 Merge pull request apache#1128 from python-driver/python-1304 Fix jenkins builds (apache#1134) Minor refactor of prior commit Handle "log gone" case in the end of _run_loop (apache#1133) HostFilterPolicyInitTest fix for Python 3.11 (apache#1131) Groovy fixes Hey, let's actually update the right things, shall we? Smaller smoke test configuration to avoid explosion of test builds in AWS Fix to prior fix ...
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.