Skip to content

Fix AwaitMessageSensor not honoring timeout #62104

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
vincbeck merged 4 commits into from
Mar 12, 2026
+44 −0
Merged

Fix AwaitMessageSensor not honoring timeout #62104

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
7e974d8
Fix AwaitMessageSensor not honoring timeout
Pranaykarvi Feb 18, 2026
2f6a922
Run prek to fix static checks
Pranaykarvi Feb 20, 2026
c01ebd6
fix: remove unused pytest import
Pranaykarvi Mar 12, 2026
053cd89
fix: convert int/float timeout to timedelta for Airflow 2.11.x compat
Pranaykarvi Mar 12, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions providers/apache/kafka/src/airflow/providers/apache/kafka/sensors/kafka.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,6 +17,7 @@
from __future__ import annotations

from collections.abc import Callable, Sequence
from datetime import timedelta
from typing import Any

from airflow.providers.apache.kafka.triggers.await_message import AwaitMessageTrigger
Expand Down Expand Up @@ -103,6 +104,10 @@ def __init__(
self.commit_offset = commit_offset

def execute(self, context) -> Any:
if isinstance(self.timeout, (int, float)):
timeout = timedelta(seconds=self.timeout)
else:
timeout = self.timeout
self.defer(
trigger=AwaitMessageTrigger(
topics=self.topics,
Expand All @@ -115,6 +120,7 @@ def execute(self, context) -> Any:
commit_offset=self.commit_offset,
),
method_name="execute_complete",
timeout=timeout,
)

def execute_complete(self, context, event=None):
Expand Down
38 changes: 38 additions & 0 deletions providers/apache/kafka/tests/unit/apache/kafka/sensors/test_await_message.py
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,38 @@
# Licensed to the Apache Software Foundation (ASF) under one
# or more contributor license agreements. See the NOTICE file
# distributed with this work for additional information
# regarding copyright ownership. The ASF licenses this file
# to you under the Apache License, Version 2.0 (the
# "License"); you may not use this file except in compliance
# with the License. You may obtain a copy of the License at
#
# http://www.apache.org/licenses/LICENSE-2.0
#
# Unless required by applicable law or agreed to in writing,
# software distributed under the License is distributed on an
# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
# KIND, either express or implied. See the License for the
# specific language governing permissions and limitations
# under the License.
from __future__ import annotations

from datetime import timedelta

from airflow.providers.apache.kafka.sensors.kafka import AwaitMessageSensor


def test_await_message_sensor_passes_timeout(mocker):
"""Regression test for #62097: user-provided timeout must be passed to defer()."""
sensor = AwaitMessageSensor(
task_id="test",
topics=["test"],
apply_function="builtins.print",
timeout=timedelta(seconds=30),
)

defer_mock = mocker.patch.object(sensor, "defer")

sensor.execute({})

defer_mock.assert_called_once()
assert defer_mock.call_args.kwargs["timeout"] == timedelta(seconds=30)
Loading