fix(docs-infra): restyle prefer/avoid code block headers#69646
Open
erkamyaman wants to merge 1 commit into
Open
fix(docs-infra): restyle prefer/avoid code block headers#69646erkamyaman wants to merge 1 commit into
erkamyaman wants to merge 1 commit into
Conversation
The "Prefer" / "Avoid" code block headers rendered the style label as plain inline text joined to the title with a bare "-" separator, giving the two block types little visual distinction. The taller label also left the prefer/avoid header at a different height from the plain filename header, so the copy button's single "top" value could not center it in both. Style the label as a small uppercased pill tinted with the block's style color, drop the "-" separator, add a subtle inset accent under the header, and swap the heavier "dangerous" icon on "Avoid" for "close". Give every header a fixed height with box-sizing: border-box and vertically center its contents so all variants render at the same height and the copy button stays centered. This supersedes angular#69638, folding in its centering fix for the copy button offset that angular#69030 introduced.
angular-robot
Bot
added
the
area: docs-infra
14 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This reworks the styling of the "Prefer" / "Avoid"
docs-codeblockheaders so the two block types are easier to tell apart, and gives every
header variant the same height so the copy button stays centered.
Supersedes #69638, folding in its centering fix for the copy button offset
that #69030 introduced.
closes #69644
PR Checklist
Please check that your PR fulfills the following requirements:
PR Type
What kind of change does this PR introduce?
What is the current behavior?
What is the new behavior?
Does this PR introduce a breaking change?