Skip to content
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .github/workflows/dependency-review.yml
Original file line number Diff line number Diff line change
Expand Up @@ -17,4 +17,4 @@ jobs:
- name: 'Checkout Repository'
uses: actions/checkout@v4
- name: 'Dependency Review'
uses: actions/dependency-review-action@v4
uses: actions/dependency-review-action@v4
12 changes: 6 additions & 6 deletions .github/workflows/license.yml
Original file line number Diff line number Diff line change
@@ -1,17 +1,17 @@
name: Update copyright year(s) in license file

permissions:
pull-requests: write
contents: write
pull-requests: write
contents: write

on:
schedule:
- cron: '0 3 1 1 *' # 03:00 AM on January 1
workflow_dispatch:
workflow_dispatch:
inputs:
name:
description: "this is an input"
default: "yes"
name:
description: 'this is an input'
default: 'yes'
jobs:
update-license-year:
runs-on: ubuntu-latest
Expand Down
1 change: 0 additions & 1 deletion CONTRIBUTING.md
Original file line number Diff line number Diff line change
Expand Up @@ -123,7 +123,6 @@ Before you submit your Pull Request (PR) consider the following guidelines:

- In GitHub, send a pull request to `angular-split:main`.
- If we suggest changes then:

- Make the required updates.
- Re-run the test suites to ensure tests are still passing.
- Rebase your branch and force push to your GitHub repository (this will update your Pull Request):
Expand Down
6 changes: 4 additions & 2 deletions package-lock.json

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

5 changes: 3 additions & 2 deletions package.json
Original file line number Diff line number Diff line change
Expand Up @@ -21,7 +21,8 @@
"ng": "ng",
"start": "wireit",
"prepare": "husky install",
"release": "npm run release --workspaces"
"release": "npm run release --workspaces",
"prettier": "prettier --write ."
},
"private": true,
"dependencies": {
Expand Down Expand Up @@ -68,7 +69,7 @@
"lint-staged": "^14.0.1",
"ng-packagr": "^20.1.0",
"postcss": "8.4.28",
"prettier": "^3.0.2",
"prettier": "^3.8.1",
"serve": "^14.2.1",
"ts-node": "10.9.1",
"tslib": "^2.6.2",
Expand Down
2 changes: 1 addition & 1 deletion projects/angular-split/src/lib/split/split.component.html
Original file line number Diff line number Diff line change
Expand Up @@ -33,7 +33,7 @@
gutterNum: $index + 1,
first: $first,
last: $index === _areas().length - 2,
isDragged: draggedGutterIndex() === $index
isDragged: draggedGutterIndex() === $index,
};
injector: injector
"
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -158,7 +158,8 @@ export class GutterClickRollUnrollComponent extends AComponent implements AfterV
setTimeout(() => {
const logsEl = this.logsEl()
if (logsEl.nativeElement.scroll) {
(<HTMLElement>logsEl.nativeElement).scroll({ top: this.logMessages.length * 30 })
const element = logsEl.nativeElement as HTMLElement
element.scroll({ top: this.logMessages.length * 30 })
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Like it, but it doesn't have to do with prettier? Perhaps update the pr description for the other things.

Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Due to semi false prettier adds with the previous way a ; at the beginning which is then marked by eslint.
The solution is either to separate like I did here or change semi to true

}
})

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -267,7 +267,8 @@ export class SplitTransitionsComponent extends AComponent {
setTimeout(() => {
const logsEl = this.logsEl()
if (logsEl.nativeElement.scroll) {
(<HTMLElement>logsEl.nativeElement).scroll({ top: this.logMessages.length * 30 })
const element = logsEl.nativeElement as HTMLElement
element.scroll({ top: this.logMessages.length * 30 })
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same here.
I don't mind those better typings, but it is very drive-by

}
})
}
Expand Down
Loading