Skip to content

refactor(@angular-devkit/build-angular): allow @angular/core version 0.0.0 #16267

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
mgechev merged 1 commit into from
Nov 22, 2019
Merged

refactor(@angular-devkit/build-angular): allow @angular/core version 0.0.0 #16267

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
refactor(@angular-devkit/build-angular): allow @angular/core version … 
…0.0.0

Allow version "0.0.0" for integration testing in the angular/angular repository with the generated development @angular/core npm package which is versioned "0.0.0".
This is a pre-req for angular/angular#33927 which runs integration tests against the bazel generated npm packages.
  • Loading branch information
@gregmagolan
gregmagolan committed Nov 22, 2019
commit 79cbe71c0398c8bc63533682af9ea057c96ed96b
5 changes: 3 additions & 2 deletions packages/angular_devkit/build_angular/src/utils/version.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -59,9 +59,10 @@ export function assertCompatibleAngularVersion(projectRoot: string, logger: logg

const cliMajor = new SemVer(angularCliPkgJson['version']).major;
// e.g. CLI 8.0 supports '>=8.0.0 <9.0.0', including pre-releases (betas, rcs, snapshots)
// of both 8 and 9.
// of both 8 and 9. Also allow version "0.0.0" for integration testing in the angular/angular
// repository with the generated development @angular/core npm package which is versioned "0.0.0".
const supportedAngularSemver =
`^${cliMajor}.0.0-beta || ` + `>=${cliMajor}.0.0 <${cliMajor + 1}.0.0`;
`0.0.0 || ^${cliMajor}.0.0-beta || ` + `>=${cliMajor}.0.0 <${cliMajor + 1}.0.0`;

const angularVersion = new SemVer(angularPkgJson['version']);
const rxjsVersion = new SemVer(rxjsPkgJson['version']);
Expand Down