stop ngDoCheck() occuring for detached nodes#9351
Closed
timruffles wants to merge 1 commit into
Closed
Conversation
NOTE - this needs tests, and isn't for merging yet - with detached change detector no checking occurs, yet the lifecycle hooks fire
3 tasks
Contributor
Author
|
Closed - didn't see #9317 does this, and has tests already. |
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Relating to #7055 #7054
What kind of change does this PR introduce? (check one with "x")
What is the current behavior? (You can also link to an open issue here)
ngDoCheck, ngAfterViewChecked are called even when no checking has taken place, due to the change detector being detached.
What is the new behavior?
They are not called at the wrong time.
Does this PR introduce a breaking change? (check one with "x")
Not sure yet!
If this PR contains a breaking change, please describe the impact and migration path for existing applications: ...
Other information:
NOTE - this needs tests, and isn't for merging yet
yet the lifecycle hooks fire