fix(ChangeDetection): ngAfterViewChecked is called when ChangeDetecto…#9309
Closed
alfonso-presa wants to merge 1 commit into
Closed
fix(ChangeDetection): ngAfterViewChecked is called when ChangeDetecto…#9309alfonso-presa wants to merge 1 commit into
alfonso-presa wants to merge 1 commit into
Conversation
…r is detached ngDoCheck, ngAfterViewChecked, ngAfterContentChecked and ngOnChanges should not be invoked when ChangeDetector is detached. fixes angular#7057
Contributor
|
Looks good after a quick look over. Why did you end up closing it? |
Contributor
|
Ah right - you're referring to |
Contributor
Author
|
Yes... that reference was created by my own test :-S. Anyway I uploaded this one #9317 which I think is the good way of handling the issue. |
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Please check if the PR fulfills these requirements
What kind of change does this PR introduce? (check one with "x")
What is the current behavior? (You can also link to an open issue here)
When ChangeDetector is detached ngViewChecked, ngContentChecked, ngDoChecked and ngOnChanges are triggered during a CD cycle.
What is the new behavior?
When ChangeDetector is detached ngViewChecked, ngContentChecked, ngDoChecked and ngOnChanges are NOT triggered during the CD cycle.
Does this PR introduce a breaking change? (check one with "x")
If this PR contains a breaking change, please describe the impact and migration path for existing applications: ...
Other information:
ngDoCheck, ngAfterViewChecked, ngAfterContentChecked and ngOnChanges should not be invoked when ChangeDetector is detached.
fixes #7054