Skip to content

G3_MASTER: Ignore unused import strong-mode warnings in generated Dart code #8693

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
jeffbcross merged 1 commit into from
May 19, 2016
Merged

G3_MASTER: Ignore unused import strong-mode warnings in generated Dart code #8693

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 7 additions & 0 deletions modules_dart/transform/lib/src/transform/common/code/ng_deps_code.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -127,6 +127,8 @@ class NgDepsWriter extends Object
: this.buffer = buffer != null ? buffer : new StringBuffer();
}

const _ignoredProblems = const <String>['UNUSED_IMPORT', 'UNUSED_SHOWN_NAME'];

abstract class NgDepsWriterMixin
implements
AnnotationWriterMixin,
Expand All @@ -137,6 +139,11 @@ abstract class NgDepsWriterMixin
StringBuffer get buffer;

void writeNgDepsModel(NgDepsModel model) {
// Avoid strong-mode warnings about unused imports.
for (var problem in _ignoredProblems) {
buffer.writeln('// @ignoreProblemForFile $problem');
}

if (model.libraryUri.isNotEmpty) {
buffer.writeln('library ${model.libraryUri}${TEMPLATE_EXTENSION};\n');
}
Expand Down
2 changes: 2 additions & 0 deletions modules_dart/transform/test/transform/integration/deferred_files/expected/bar.template.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,3 +1,5 @@
// @ignoreProblemForFile UNUSED_IMPORT
// @ignoreProblemForFile UNUSED_SHOWN_NAME
library bar.template.dart;

import 'bar.dart';
Expand Down
2 changes: 2 additions & 0 deletions ...art/transform/test/transform/integration/directive_chain_files/expected/bar.template.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,3 +1,5 @@
// @ignoreProblemForFile UNUSED_IMPORT
// @ignoreProblemForFile UNUSED_SHOWN_NAME
library bar.template.dart;

import 'bar.dart';
Expand Down
2 changes: 2 additions & 0 deletions ..._dart/transform/test/transform/integration/directive_dep_files/expected/bar.template.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,3 +1,5 @@
// @ignoreProblemForFile UNUSED_IMPORT
// @ignoreProblemForFile UNUSED_SHOWN_NAME
library bar.template.dart;

import 'bar.dart';
Expand Down
2 changes: 2 additions & 0 deletions ..._dart/transform/test/transform/integration/empty_ng_deps_files/expected/foo.template.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,3 +1,5 @@
// @ignoreProblemForFile UNUSED_IMPORT
// @ignoreProblemForFile UNUSED_SHOWN_NAME
library bar.template.dart;

import 'foo.dart';
Expand Down
2 changes: 2 additions & 0 deletions ...s_dart/transform/test/transform/integration/event_getter_files/expected/bar.template.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,3 +1,5 @@
// @ignoreProblemForFile UNUSED_IMPORT
// @ignoreProblemForFile UNUSED_SHOWN_NAME
library bar.template.dart;

import 'bar.dart';
Expand Down
2 changes: 2 additions & 0 deletions ..._dart/transform/test/transform/integration/list_of_types_files/expected/bar.template.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,3 +1,5 @@
// @ignoreProblemForFile UNUSED_IMPORT
// @ignoreProblemForFile UNUSED_SHOWN_NAME
library bar.template.dart;

import 'bar.dart';
Expand Down
2 changes: 2 additions & 0 deletions ...transform/test/transform/integration/override_annotation_files/expected/bar.template.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,3 +1,5 @@
// @ignoreProblemForFile UNUSED_IMPORT
// @ignoreProblemForFile UNUSED_SHOWN_NAME
library bar.template.dart;

import 'bar.dart';
Expand Down
2 changes: 2 additions & 0 deletions ...form/test/transform/integration/queries_class_annotation_files/expected/bar.template.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,3 +1,5 @@
// @ignoreProblemForFile UNUSED_IMPORT
// @ignoreProblemForFile UNUSED_SHOWN_NAME
library bar.template.dart;

import 'bar.dart';
Expand Down
2 changes: 2 additions & 0 deletions ...sform/test/transform/integration/queries_prop_annotation_files/expected/bar.template.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,3 +1,5 @@
// @ignoreProblemForFile UNUSED_IMPORT
// @ignoreProblemForFile UNUSED_SHOWN_NAME
library bar.template.dart;

import 'bar.dart';
Expand Down
2 changes: 2 additions & 0 deletions ...t/transform/test/transform/integration/simple_annotation_files/expected/bar.template.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,3 +1,5 @@
// @ignoreProblemForFile UNUSED_IMPORT
// @ignoreProblemForFile UNUSED_SHOWN_NAME
library bar.template.dart;

import 'bar.dart';
Expand Down
2 changes: 2 additions & 0 deletions ...transform/test/transform/integration/simple_annotation_files/expected/index.template.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,3 +1,5 @@
// @ignoreProblemForFile UNUSED_IMPORT
// @ignoreProblemForFile UNUSED_SHOWN_NAME
library web_foo.template.dart;

import 'index.dart';
Expand Down
2 changes: 2 additions & 0 deletions ...dart/transform/test/transform/integration/synthetic_ctor_files/expected/bar.template.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,3 +1,5 @@
// @ignoreProblemForFile UNUSED_IMPORT
// @ignoreProblemForFile UNUSED_SHOWN_NAME
library bar.template.dart;

import 'bar.dart';
Expand Down
2 changes: 2 additions & 0 deletions ...art/transform/test/transform/integration/two_annotations_files/expected/bar.template.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,3 +1,5 @@
// @ignoreProblemForFile UNUSED_IMPORT
// @ignoreProblemForFile UNUSED_SHOWN_NAME
library bar.template.dart;

import 'bar.dart';
Expand Down
2 changes: 2 additions & 0 deletions modules_dart/transform/test/transform/integration/two_deps_files/expected/bar.template.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,3 +1,5 @@
// @ignoreProblemForFile UNUSED_IMPORT
// @ignoreProblemForFile UNUSED_SHOWN_NAME
library bar.template.dart;

import 'bar.dart';
Expand Down