Skip to content

G3_MASTER: Ignore unused import strong-mode warnings in generated Dart code#8693

Merged
jeffbcross merged 1 commit into
angular:g3_masterfrom
ochafik:ochafik-ignore-unused-imports-warnings-g3_master
May 19, 2016
Merged

G3_MASTER: Ignore unused import strong-mode warnings in generated Dart code#8693
jeffbcross merged 1 commit into
angular:g3_masterfrom
ochafik:ochafik-ignore-unused-imports-warnings-g3_master

Conversation

@ochafik

@ochafik ochafik commented May 17, 2016

Copy link
Copy Markdown

Please check if the PR fulfills these requirements

What kind of change does this PR introduce? (Bug fix, feature, docs update, ...)

  • Bugfix
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • CI related changes
  • Other... Please describe:

What is the current behavior? (You can also link to an open issue here)

Generated code triggers lots of unused import warnings with dartanalyzer --strong.

What is the new behavior?

Unused imports and unused "shown" names in imports in generated are silently ignored by the Dart analyzer in strong-mode.

Does this PR introduce a breaking change?

  • Yes
  • No

Other information:

@tbosch

tbosch commented May 17, 2016

Copy link
Copy Markdown
Contributor

FYI, you can run the transformer unit tests via gulp test.unit.dartvm. Travis failed because some of them are failing...

@tbosch

tbosch commented May 17, 2016

Copy link
Copy Markdown
Contributor

Also, regarding the failures in the jobs typescript_next and dart_dev: These are because Typescript and Dart have more checks now. Rebase this PR ontop of my PR #8680 which contains fixes to these and which I will land ASAP.

@tbosch tbosch changed the title Ignore unused import strong-mode warnings in generated Dart code G3_MASTER: Ignore unused import strong-mode warnings in generated Dart code May 17, 2016
@tbosch tbosch added pr_state: LGTM action: cleanup The PR is in need of cleanup, either due to needing a rebase or in response to comments from reviews labels May 17, 2016
@ochafik ochafik force-pushed the ochafik-ignore-unused-imports-warnings-g3_master branch from be7bf90 to 492f7b3 Compare May 17, 2016 15:21
@googlebot

Copy link
Copy Markdown

We found a Contributor License Agreement for you (the sender of this pull request) and all commit authors, but as best as we can tell these commits were authored by someone else. If that's the case, please add them to this pull request and have them confirm that they're okay with these commits being contributed to Google. If we're mistaken and you did author these commits, just reply here to confirm.

@ochafik ochafik force-pushed the ochafik-ignore-unused-imports-warnings-g3_master branch from 492f7b3 to 3d186a6 Compare May 17, 2016 15:24
@ochafik

ochafik commented May 17, 2016

Copy link
Copy Markdown
Author

Thanks @tbosch !
Fixed Dart test expectations + rebased onto tbosch/fix_types, but still getting a weird failure (same as in your PR) on typescript_next:

[15:31:33] Error: [DiffingTSCompiler]: Typescript found the following errors:
  /home/travis/build/angular/angular/node_modules/typescript/lib/lib.d.ts (883, 5): Duplicate identifier 'stack'.
  /home/travis/build/angular/angular/tmp/diffing_plugin_wrapper-output_path-TaBpImXX.tmp/angular2/typings/node/node.d.ts (13, 5):

@tbosch

tbosch commented May 17, 2016

Copy link
Copy Markdown
Contributor

Yes, just found it in my PR as well. Please rebase again :-)

@tbosch

tbosch commented May 17, 2016

Copy link
Copy Markdown
Contributor

(I.e. I deactivated the typescript_next build, as we don't need it to sync into G3)

@ochafik ochafik force-pushed the ochafik-ignore-unused-imports-warnings-g3_master branch from 3d186a6 to 6d486b8 Compare May 17, 2016 16:13
@tbosch tbosch added action: merge The PR is ready for merge by the caretaker and removed action: cleanup The PR is in need of cleanup, either due to needing a rebase or in response to comments from reviews labels May 17, 2016
@ochafik ochafik force-pushed the ochafik-ignore-unused-imports-warnings-g3_master branch 2 times, most recently from 9e1418b to 3bd9ca2 Compare May 18, 2016 11:01
@googlebot

Copy link
Copy Markdown

CLAs look good, thanks!

@tbosch

tbosch commented May 18, 2016

Copy link
Copy Markdown
Contributor

Ok, I finally landed everything to make g3_master green again and synced into g3.
Could you rebase again? Sorry that this takes so long, but we had accumulated a bit of technical dept...

@ochafik ochafik force-pushed the ochafik-ignore-unused-imports-warnings-g3_master branch from 3bd9ca2 to ec07cdb Compare May 19, 2016 10:38
@googlebot

Copy link
Copy Markdown

We found a Contributor License Agreement for you (the sender of this pull request) and all commit authors, but as best as we can tell these commits were authored by someone else. If that's the case, please add them to this pull request and have them confirm that they're okay with these commits being contributed to Google. If we're mistaken and you did author these commits, just reply here to confirm.

@ochafik ochafik force-pushed the ochafik-ignore-unused-imports-warnings-g3_master branch 2 times, most recently from e197681 to 2d6a6ec Compare May 19, 2016 10:42
@googlebot

Copy link
Copy Markdown

CLAs look good, thanks!

@ochafik ochafik force-pushed the ochafik-ignore-unused-imports-warnings-g3_master branch from 2d6a6ec to e9b8606 Compare May 19, 2016 10:46
@ochafik

ochafik commented May 19, 2016

Copy link
Copy Markdown
Author

Rebased :-)

@jeffbcross jeffbcross merged commit 220be8e into angular:g3_master May 19, 2016
mhevery pushed a commit that referenced this pull request May 19, 2016
mhevery pushed a commit that referenced this pull request May 19, 2016
@angular-automatic-lock-bot

Copy link
Copy Markdown

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot Bot locked and limited conversation to collaborators Sep 8, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

action: merge The PR is ready for merge by the caretaker cla: yes

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants