G3_MASTER: Ignore unused import strong-mode warnings in generated Dart code#8693
Conversation
|
FYI, you can run the transformer unit tests via |
|
Also, regarding the failures in the jobs typescript_next and dart_dev: These are because Typescript and Dart have more checks now. Rebase this PR ontop of my PR #8680 which contains fixes to these and which I will land ASAP. |
be7bf90 to
492f7b3
Compare
|
We found a Contributor License Agreement for you (the sender of this pull request) and all commit authors, but as best as we can tell these commits were authored by someone else. If that's the case, please add them to this pull request and have them confirm that they're okay with these commits being contributed to Google. If we're mistaken and you did author these commits, just reply here to confirm. |
492f7b3 to
3d186a6
Compare
|
Thanks @tbosch ! |
|
Yes, just found it in my PR as well. Please rebase again :-) |
|
(I.e. I deactivated the typescript_next build, as we don't need it to sync into G3) |
3d186a6 to
6d486b8
Compare
9e1418b to
3bd9ca2
Compare
|
CLAs look good, thanks! |
|
Ok, I finally landed everything to make g3_master green again and synced into g3. |
3bd9ca2 to
ec07cdb
Compare
|
We found a Contributor License Agreement for you (the sender of this pull request) and all commit authors, but as best as we can tell these commits were authored by someone else. If that's the case, please add them to this pull request and have them confirm that they're okay with these commits being contributed to Google. If we're mistaken and you did author these commits, just reply here to confirm. |
e197681 to
2d6a6ec
Compare
|
CLAs look good, thanks! |
2d6a6ec to
e9b8606
Compare
|
Rebased :-) |
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Please check if the PR fulfills these requirements
What kind of change does this PR introduce? (Bug fix, feature, docs update, ...)
What is the current behavior? (You can also link to an open issue here)
Generated code triggers lots of unused import warnings with
dartanalyzer --strong.What is the new behavior?
Unused imports and unused "shown" names in imports in generated are silently ignored by the Dart analyzer in strong-mode.
Does this PR introduce a breaking change?
Other information: