G3_MASTER: Fix types of _componentProviders in application_ref for dart#8680
Closed
tbosch wants to merge 6 commits into
Closed
G3_MASTER: Fix types of _componentProviders in application_ref for dart#8680tbosch wants to merge 6 commits into
_componentProviders in application_ref for dart#8680tbosch wants to merge 6 commits into
Conversation
mhevery
added
pr_state: LGTM
action: merge
tbosch
force-pushed
the
fix_types
branch
2 times, most recently
from
534ffd3 to
9f6a962
Compare
tbosch
force-pushed
the
fix_types
branch
3 times, most recently
from
ad4a3f9 to
3add20d
Compare
tbosch
changed the title
_componentProviders in application_ref for dart_componentProviders in application_ref for dart
|
We found a Contributor License Agreement for you (the sender of this pull request) and all commit authors, but as best as we can tell these commits were authored by someone else. If that's the case, please add them to this pull request and have them confirm that they're okay with these commits being contributed to Google. If we're mistaken and you did author these commits, just reply here to confirm. |
tbosch
changed the title
_componentProviders in application_ref for dart_componentProviders in application_ref for dart
|
CLAs look good, thanks! |
12 tasks
The list is otherwise reified as `List<Provider>` but non-Provider objects are later appended to it
needed for ts next
This is not needed for syncing Dart into G3, and we are testing against typescript_next on the real master.
tbosch
force-pushed
the
fix_types
branch
8 times, most recently
from
1ca961e to
31ddd9c
Compare
tbosch
added a commit
that referenced
this pull request
May 17, 2016
Contributor
Author
|
Merged into |
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.