fix(compiler): report unknown property bindings on explicit ng-templa…#69640
Open
aparzi wants to merge 1 commit into
Open
fix(compiler): report unknown property bindings on explicit ng-templa…#69640aparzi wants to merge 1 commit into
aparzi wants to merge 1 commit into
Conversation
angular-robot
Bot
added
the
area: compiler
…te elements Previously, property bindings on `<ng-template>` that were not claimed by a matched directive were silently ignored by the type checker. This was inconsistent with how bindings on regular elements are handled. Fixes 69322
aparzi
force-pushed
the
feat-compiler-missing-import-in-template
branch
from
4b5c505 to
f5a5d21
Compare
Contributor
Author
|
This PR introduce a little Breaking Change. Existing code that has unused properties in directives will receive a compiler error. |
Member
|
Presubmit came back green. I'll have to run a TGP to see how many breakages it triggers. This will help us determine how we can land this change. |
Contributor
Author
Let me know how the TGP looks. I'm ready to help with any adjustments or schematics if it triggers some internal breakages. Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Previously, property bindings on
<ng-template>that were not claimed by a matched directive were silently ignored by the type checker. This was inconsistent with how bindings on regular elements are handled.PR Checklist
Please check if your PR fulfills the following requirements:
PR Type
What kind of change does this PR introduce?
What is the current behavior?
Issue Number: #69322
Does this PR introduce a breaking change?
Templates that bind unknown properties on
<ng-template>will now produce a compilation error.