fix(docs-infra): prevent tab labels from being clipped#69639
Open
erkamyaman wants to merge 1 commit into
Open
Conversation
The active docs tab applied a 2px bottom border that inactive tabs lacked, which shrank the active label's content box and clipped its descenders. It also set `line-height: 1.5` only on the active label, so switching tabs nudged the text. Reserve the border as transparent on every tab and recolor it on the active one, and share the label `line-height`, so the letters are no longer cut and the label stays put when switching.
angular-robot
Bot
added
the
area: docs-infra
Contributor
Author
|
The videos are from https://angular.dev/guide/drag-drop#create-draggable-elements but also can be spotted in https://angular.dev/installation#install-angular-cli |
JeanMeche
approved these changes
Jul 4, 2026
JeanMeche
left a comment
JeanMeche
left a comment
Member
There was a problem hiding this comment.
that was really subtle, good catch :D
JeanMeche
added
action: merge
Contributor
Author
Until I'm 90, I'm gonna carry on finding these little weird issues in adev :) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The active docs tab applied a 2px bottom border that inactive tabs lacked, which shrank the active label's content box and clipped its descenders. It also set
line-height: 1.5only on the active label, so switching tabs nudged the text. Reserve the border as transparent on every tab and recolor it on the active one, and share the labelline-height, so the letters are no longer cut and the label stays put when switching.PR Checklist
Please check that your PR fulfills the following requirements:
PR Type
What kind of change does this PR introduce?
What is the current behavior?
Screen.Recording.2026-07-03.at.22.26.35.mov
What is the new behavior?
Screen.Recording.2026-07-03.at.22.27.04.mov
Does this PR introduce a breaking change?