Skip to content

add target="_blank" to external links in @see JSDoc tags#69594

Open
MeAkib wants to merge 1 commit into
angular:mainfrom
MeAkib:fix/#69593
Open

add target="_blank" to external links in @see JSDoc tags#69594
MeAkib wants to merge 1 commit into
angular:mainfrom
MeAkib:fix/#69593

Conversation

@MeAkib

@MeAkib MeAkib commented Jun 30, 2026

Copy link
Copy Markdown
Contributor

External links rendered via @see {@link ...} and @see [label](url) were not opening in a new tab. The getHtmlAdditionalLinks function now sets target: '_blank' on LinkEntryRenderable objects whose URL is external, and docs-pill-row.tsx passes the target attribute to the rendered anchor tag.

Fixes: #69593

@pullapprove pullapprove Bot requested a review from kirjs June 30, 2026 20:15
erkamyaman
erkamyaman reviewed Jun 30, 2026
View reviewed changes

@erkamyaman erkamyaman left a comment •
edited
Loading

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The scope of the PR is wrong, it should be docs-infra. See for more https://github.com/angular/angular/blob/main/contributing-docs%2Fcommit-message-guidelines.md If I remember correctly there is no such scope as adev

@angular-robot angular-robot Bot added the area: docs-infra Angular.dev application and infrastructure label Jul 1, 2026
@ngbot ngbot Bot added this to the Backlog milestone Jul 1, 2026
@MeAkib

MeAkib commented Jul 1, 2026

Copy link
Copy Markdown
Contributor Author

The scope of the PR is wrong, it should be docs-infra. See for more https://github.com/angular/angular/blob/main/contributing-docs%2Fcommit-message-guidelines.md If I remember correctly there is no such scope as adev

Oops, I missed it. Thanks

@MeAkib MeAkib changed the title fix(adev): add target="_blank" to external links in @see JSDoc tags add target="_blank" to external links in @see JSDoc tags Jul 1, 2026
hawkgs
hawkgs reviewed Jul 1, 2026
View reviewed changes
Comment thread adev/shared-docs/pipeline/api-gen/rendering/test/transforms/jsdoc-transforms.spec.mts Outdated
@hawkgs hawkgs removed the request for review from kirjs July 1, 2026 07:11
@github-actions

github-actions Bot commented Jul 1, 2026 •
edited
Loading

Copy link
Copy Markdown

Deployed adev-preview for b90b0c9 to: https://ng-dev-previews-fw--pr-angular-angular-69594-adev-prev-9ofhpvbg.web.app

Note: As new commits are pushed to this pull request, this link is updated after the preview is rebuilt.

JeanMeche
JeanMeche approved these changes Jul 1, 2026
View reviewed changes

@JeanMeche JeanMeche left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you make sure to fix the unit tests

@JeanMeche JeanMeche added action: cleanup The PR is in need of cleanup, either due to needing a rebase or in response to comments from reviews target: patch This PR is targeted for the next patch release labels Jul 1, 2026
@MeAkib
fix(docs-infra): add target="_blank" to external links in @see JSDoc …
b90b0c9 
…tags

External links rendered via `@see {@link ...}` and `@see [label](url)`
were not opening in a new tab. The `getHtmlAdditionalLinks` function
now sets `target: '_blank'` on `LinkEntryRenderable` objects whose URL
is external, and `docs-pill-row.tsx` passes the `target` attribute to
the rendered anchor tag.

Fixes: angular#69593
@angular-robot angular-robot Bot requested a review from JeanMeche July 1, 2026 15:46
@MeAkib MeAkib requested a review from hawkgs July 1, 2026 15:46
@JeanMeche JeanMeche added action: merge The PR is ready for merge by the caretaker and removed action: cleanup The PR is in need of cleanup, either due to needing a rebase or in response to comments from reviews labels Jul 1, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@JeanMeche JeanMeche JeanMeche approved these changes
@hawkgs hawkgs hawkgs approved these changes
+1 more reviewer
@erkamyaman erkamyaman erkamyaman left review comments
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

action: merge The PR is ready for merge by the caretaker adev: preview area: docs-infra Angular.dev application and infrastructure target: patch This PR is targeted for the next patch release

Projects

None yet

Milestone

Backlog

Development

Successfully merging this pull request may close these issues.

External link opens in same tab

4 participants

@MeAkib @JeanMeche @hawkgs @erkamyaman