fix(forms): run metadata create lifecycle after node is fully constructed#67808
Merged
leonsenft merged 1 commit intoangular:mainfrom Mar 24, 2026
Merged
fix(forms): run metadata create lifecycle after node is fully constructed#67808leonsenft merged 1 commit intoangular:mainfrom
leonsenft merged 1 commit intoangular:mainfrom
Conversation
alxhub
added
target: major
leonsenft
approved these changes
Mar 23, 2026
…ndefined This improves compatibility with TypeScript's exactOptionalPropertyTypes. Fixes angular#67246
thePunderWoman
approved these changes
Mar 23, 2026
Contributor
thePunderWoman
left a comment
thePunderWoman
left a comment
There was a problem hiding this comment.
LGTM, just a couple of suggestions
reviewed-for: fw-general, public-api
alxhub
added
action: merge
Member
Author
|
Caretaker: presubmit is "green" |
Contributor
|
This PR was merged into the repository. The changes were merged into the following branches:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Updates MetadataKey.create() to accept FieldState as the first argument, and moves its execution from the FieldMetadataState constructor to a runMetadataCreateLifecycle() method called at the end of the FieldNode constructor. This ensures the FieldNode is fully constructed before any metadata create operations run.
Fixes #67769