docs(forms): clarify disabled FormArray value behavior#67776
Open
angular-bootstrap wants to merge 1 commit intoangular:mainfrom
Open
docs(forms): clarify disabled FormArray value behavior#67776angular-bootstrap wants to merge 1 commit intoangular:mainfrom
angular-bootstrap wants to merge 1 commit intoangular:mainfrom
Conversation
Document that FormArray.value includes only enabled child controls when the array is enabled, but includes all child values when the FormArray itself is disabled. Fixes angular#67759
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Clarifies the
FormArrayAPI docs around disabled state and aggregated values.The current implementation includes all child values when the
FormArrayitself is disabled, but theAbstractControl.valuedocs only described the enabled-controls case forFormArray. This made the behavior look inconsistent, especially compared with the existingFormGroupwording.This updates the docs to make two things explicit:
FormArrayaggregates the values of enabled child controlsFormArrayaggregates the values of all child controlsFormArrayare disabled, the array itself becomes disabledFixes #67759