Skip to content

docs(docs-infra): Fix combobox dialog styles for dark theme#66245

Merged
kirjs merged 1 commit intoangular:mainfrom
SkyZeroZx:docs/fixed-dialog-theme
Jan 7, 2026
Merged

docs(docs-infra): Fix combobox dialog styles for dark theme#66245
kirjs merged 1 commit intoangular:mainfrom
SkyZeroZx:docs/fixed-dialog-theme

Conversation

@SkyZeroZx
Copy link
Copy Markdown
Contributor

Fixes combobox dialog styles to ensure correct text color and contrast in dark theme. This improves readability and visual consistency when using the docs in dark mode.

What is the current behavior?

Currently, it is not displaying correctly when we are in dark theme mode.
image

What is the new behavior?

image

@pullapprove pullapprove bot requested a review from alan-agius4 December 24, 2025 19:29
@angular-robot angular-robot bot added area: docs Related to the documentation area: docs-infra Angular.dev application and infrastructure labels Dec 24, 2025
@ngbot ngbot bot added this to the Backlog milestone Dec 24, 2025
@JeanMeche
Copy link
Copy Markdown
Member

When #66048 lands, I plan to isolate all our examples in a shadow DOM, where we don't have access to custom props defined in parents.

Like I already suggested in #66050, we should probably use a combination of css custom props + a fallback value.

Fixes combobox dialog styles to ensure correct text color and contrast in dark theme.
This improves readability and visual consistency when using the docs in dark mode.
@SkyZeroZx SkyZeroZx force-pushed the docs/fixed-dialog-theme branch from 2a2a194 to 575f975 Compare December 24, 2025 23:27
@JeanMeche JeanMeche requested review from JeanMeche and removed request for alan-agius4 January 4, 2026 01:37
@JeanMeche JeanMeche added action: merge The PR is ready for merge by the caretaker target: patch This PR is targeted for the next patch release labels Jan 7, 2026
@github-actions
Copy link
Copy Markdown

github-actions bot commented Jan 7, 2026

Deployed adev-preview for 575f975 to: https://ng-dev-previews-fw--pr-angular-angular-66245-adev-prev-6aj3bdt8.web.app

Note: As new commits are pushed to this pull request, this link is updated after the preview is rebuilt.

@kirjs kirjs merged commit 090484c into angular:main Jan 7, 2026
24 checks passed
@kirjs
Copy link
Copy Markdown
Contributor

kirjs commented Jan 7, 2026

This PR was merged into the repository. The changes were merged into the following branches:

@angular-automatic-lock-bot
Copy link
Copy Markdown

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Feb 7, 2026
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

action: merge The PR is ready for merge by the caretaker adev: preview area: docs Related to the documentation area: docs-infra Angular.dev application and infrastructure target: patch This PR is targeted for the next patch release

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants