docs(docs-infra): Fix toggle button in dark mode#66050
Merged
thePunderWoman merged 1 commit intoangular:mainfrom Jan 8, 2026
Merged
docs(docs-infra): Fix toggle button in dark mode#66050thePunderWoman merged 1 commit intoangular:mainfrom
thePunderWoman merged 1 commit intoangular:mainfrom
Conversation
angular-robot
bot
added
area: docs
Member
|
I don't think we'll want to pull the ThemeService in our examples. I would suggest we use some of the css custom properties that are theme dependents with a fallback value. |
JeanMeche
requested review from
JeanMeche
and removed request for
devversion
aparzi
force-pushed
the
fix-toggle-button-in-dark-mode
branch
from
037101d to
dfdeb67
Compare
JeanMeche
approved these changes
Jan 8, 2026
JeanMeche
added
action: merge
Contributor
|
@aparzi Looks like this is failing lint. Can you take a look? |
thePunderWoman
added
action: cleanup
Fix visibility toggle button in dark mode Fix angular#66049
aparzi
force-pushed
the
fix-toggle-button-in-dark-mode
branch
from
dfdeb67 to
b782261
Compare
Contributor
Author
I should have fixed the lint errors |
thePunderWoman
added
action: merge
JeanMeche
approved these changes
Jan 8, 2026
Contributor
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix visibility toggle button in dark mode
Fix #66049
PR Checklist
Please check if your PR fulfills the following requirements:
PR Type
What kind of change does this PR introduce?
Issue Number: #66049
What is the new behavior?
Fix visibility in dark mode documentation
Does this PR introduce a breaking change?