docs(aria): add required 'value' to ngMenuItem json#65721
Closed
msmallest wants to merge 1 commit into
Closed
Conversation
The `value` is a required input. Without it, `menu.ts` will say "Required input 'value' from directive MenuItem must be specified.
Member
|
Those files are automatically generated from the JSdocs on the components repo. Can you please open a PR there ? |
Contributor
|
Sounds good, got one open there angular/components#32440 |
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
valueis a required input. Without it,menu.tswill throw the error "Required input 'value' from directive MenuItem must be specified."PR Checklist
Please check if your PR fulfills the following requirements:
PR Type
What kind of change does this PR introduce?
What is the current behavior?
Issue Number: N/A
What is the new behavior?
valuefor eachngMenuItemin the API entriesDoes this PR introduce a breaking change?
Other information
The Aria menu package's jsdocs were also missing the values, so there is an associated PR in its repo: angular/components#32440