@mturco it looks like the signalGetFn is actually unused in the primitives / Angular code. Which would mean that exporting it would put new usages on a otherwise unused code path.

FYI, Angular is using https://github.com/angular/angular/blob/main/packages/core/primitives/signals/src/signal.ts#L57-L60 which seems to have the same logic as signalGetFn.

Would love to know more about the intention / other possibilities here.

@pkozlowski-opensource the use case here is related to go/wiz:devtools-reactive-nodes.

We're using the recently added postProducerCreatedFn to hook into signal creation. This hook (like postSignalSetFn) passes the reactive node itself and not the getter function. So when we go to provide devtools with the signals a component created, we need a way to also provide the current value.

We could pass () => node.value to devtools but that wouldn't create a subscription so the extension UI would not update on signal writes. I suppose that could be mitigated by having that function also manually call producerAccessed? Would that be preferred to introducing usage of signalGetFn?

@pkozlowski-opensource this has been updated as discussed to have createSignal call signalGetFn which should align Wiz/Angular on the latter being the singular way we create getters.

I see that you just added the action: merge label, but the following checks are still failing:
     status "google-internal-tests" is failing
     2 pending code reviews

If you want your PR to be merged, it has to pass all the CI checks.

If you can't get the PR to a green state due to flakes or broken main, please try rebasing to main and/or restarting the CI job. If that fails and you believe that the issue is not due to your change, please contact the caretaker and ask for help.

TESTED=see above presubmit (TGP not necessary for new code)

caretaker note: failure is unrelated. This is ready to merge.

This PR was merged into the repository by commit a4bad8d.

The changes were merged into the following branches: main

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

_{This action has been performed automatically by a bot.}