fix(core): remove unused parameter from listener instruction#60406
Closed
crisbeto wants to merge 1 commit intoangular:mainfrom
Closed
fix(core): remove unused parameter from listener instruction#60406crisbeto wants to merge 1 commit intoangular:mainfrom
crisbeto wants to merge 1 commit intoangular:mainfrom
Conversation
crisbeto
added
action: review
pkozlowski-opensource
approved these changes
Mar 16, 2025
Member
pkozlowski-opensource
left a comment
pkozlowski-opensource
left a comment
There was a problem hiding this comment.
LGTM, thnx for doing this cleanup!
I'm not sure what adev job is complaining about, though...
crisbeto
force-pushed
the
listener-instruction-capture
branch
from
2eeff7f to
6a80ebe
Compare
Removes the `useCapture` parameter from the `listener` instruction, because it's not used.
crisbeto
force-pushed
the
listener-instruction-capture
branch
from
6a80ebe to
732b6b0
Compare
crisbeto
added
action: merge
Member
|
This PR was merged into the repository by commit 04d963c. The changes were merged into the following branches: main |
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Removes the
useCaptureparameter from thelistenerinstruction, because it's not used.