refactor(core): Add hydration for components that were lazy loaded#49505
Closed
jessicajaniuk wants to merge 2 commits into
Closed
refactor(core): Add hydration for components that were lazy loaded#49505jessicajaniuk wants to merge 2 commits into
jessicajaniuk wants to merge 2 commits into
Conversation
jessicajaniuk
added
action: review
AndrewKushnir
changed the title
jessicajaniuk
force-pushed
the
hydration-lazy
branch
6 times, most recently
from
cb5eb22 to
5c9652f
Compare
AndrewKushnir
approved these changes
Mar 21, 2023
Contributor
jessicajaniuk
force-pushed
the
hydration-lazy
branch
from
5c9652f to
aee55e8
Compare
This ensures that hydration still happens on components that were set up to lazy load through the router. Hydration will happen after the component has finished loading.
AndrewKushnir
force-pushed
the
hydration-lazy
branch
from
a020731 to
a567214
Compare
Contributor
|
FYI, just discussed with @pkozlowski-opensource and @atscott: the proposal is to find a better way to capture the fact that some components were instantiated after the initial rendering. We can try to do it in a more automatic way, so that there is no need to give "hints" to the hydration logic explicitly (via public API). |
AndrewKushnir
added
state: blocked
and removed
action: review
Contributor
|
Closing in favor of #49576, which would not require any changes to the public API surface. |
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This ensures that hydration still happens on components that were set up to lazy load through the router. Hydration will happen after the component has finished loading.
PR Type
What kind of change does this PR introduce?
Does this PR introduce a breaking change?