fix(core): distinguish injection tokens based on their value type by crisbeto · Pull Request #47461 · angular/angular

crisbeto · 2022-09-16T08:50:32Z

Currently the generic type of InjectionToken isn't used anywhere which means that the compiler won't flag the following as an error:

const foo = new InjectionToken<number>('foo');
const bar: InjectionToken<string> = foo; // Should be an error, but it's not.

These changes add a private property to allow the compiler to distinguish between the two.

Fixes #46815.

crisbeto · 2022-09-16T11:12:27Z

This passed a TGP so I'm assuming that it won't be particularly breaking externally either. I'll bump it up to major just in case.

devversion · 2022-09-16T12:11:04Z

Have you tested how this works when shipped to NPM?

The private modifier causes the type T to be omitted in the shipped d.t.s IIRC (see)

We use stripInternal- so the whole field would be omitted for our consumers (see)

I haven't tried packaging and testing it, but I assumed it would be fine since we have other places with these sorts of branding properties.

+1 to test this after packaging and/or add a check in one of the apps within integration folder (where apps work with built packages).

I ended up making it a public __brand__ property. We appear to be using this pattern in a few other places.

A private field is not stripped from .d.ts files, Paul's playground link shows the following .d.ts output:

export declare class X<T> { private p; }

so it should be possible to make it private, but not @internal. I like the __brand__ naming though.

yes, the field is not stripped- but the type.

Oh, how did I miss that 🤦‍♂️

AndrewKushnir

👍

AndrewKushnir

Reviewed-for: public-api

jessicajaniuk

reviewed-for: public-api

Harpush · 2023-03-28T06:08:51Z

@crisbeto any chance for it to land in v16?

crisbeto · 2023-03-28T12:40:49Z

Likely not. I haven't had the time to migrate the internal codebase to avoid the breakages.

thePunderWoman

reviewed-for: public-api

…` token cleanup related to angular/angular/pull/47461

cleanup related to angular/angular/pull/47461

Currently the generic type of `InjectionToken` isn't used anywhere which means that the compiler won't flag the following as an error: ``` const foo = new InjectionToken<number>('foo'); const bar: InjectionToken<string> = foo; // Should be an error, but it's not. ``` These changes add a private property to allow the compiler to distinguish between the two. Fixes angular#46815.

cleanup related to angular/angular/pull/47461

* refactor(material/sidenav): set generic for the `MAT_DRAWER_CONTAINER` token cleanup related to angular/angular/pull/47461 * refactor(material/chips): set generic for the `MAT_CHIP` token cleanup related to angular/angular/pull/47461 * refactor(material/slider): set generic for the `MAT_SLIDER` token cleanup related to angular/angular/pull/47461 * fixup! refactor(material/chips): set generic for the `MAT_CHIP` token * refactor(cdk/drag-drop): set generic for the `CDK_DROP_LIST_GROUP` token cleanup related to angular/angular/pull/47461

* refactor(material/sidenav): set generic for the `MAT_DRAWER_CONTAINER` token cleanup related to angular/angular/pull/47461 * refactor(material/chips): set generic for the `MAT_CHIP` token cleanup related to angular/angular/pull/47461 * refactor(material/slider): set generic for the `MAT_SLIDER` token cleanup related to angular/angular/pull/47461 * fixup! refactor(material/chips): set generic for the `MAT_CHIP` token * refactor(cdk/drag-drop): set generic for the `CDK_DROP_LIST_GROUP` token cleanup related to angular/angular/pull/47461 (cherry picked from commit 8d5a896)

angular-robot · 2026-04-17T13:59:42Z

This draft PR is being closed because it has been stale for 28 days and has seen no activity from you. If you'd like to see this change land, you can re-open this PR. Thank you for being an Angular contributor!

angular-automatic-lock-bot · 2026-05-18T00:36:11Z

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

_{This action has been performed automatically by a bot.}

crisbeto force-pushed the 46815/injection-token-types branch 3 times, most recently from a1b96f5 to 8cd5e04 Compare September 16, 2022 09:34

pkozlowski-opensource added the area: core Issues related to the framework runtime label Sep 16, 2022

ngbot Bot added this to the Backlog milestone Sep 16, 2022

pkozlowski-opensource added action: review The PR is still awaiting reviews from at least one requested reviewer target: patch This PR is targeted for the next patch release labels Sep 16, 2022

crisbeto added target: major This PR is targeted for the next major release and removed target: patch This PR is targeted for the next patch release labels Sep 16, 2022

crisbeto commented Sep 16, 2022

View reviewed changes

Comment thread packages/core/testing/src/test_bed.ts Outdated

Comment thread packages/core/src/di/injection_token.ts Outdated

crisbeto marked this pull request as ready for review September 16, 2022 11:14

pullapprove Bot requested review from AndrewKushnir and pkozlowski-opensource September 16, 2022 11:14

devversion reviewed Sep 16, 2022

View reviewed changes

crisbeto force-pushed the 46815/injection-token-types branch 2 times, most recently from e8a832c to 4cfaeb9 Compare September 19, 2022 09:44

devversion approved these changes Sep 19, 2022

View reviewed changes

AndrewKushnir approved these changes Sep 19, 2022

View reviewed changes

pullapprove Bot requested review from dylhunn and jessicajaniuk September 19, 2022 21:53

AndrewKushnir approved these changes Sep 19, 2022

View reviewed changes

jessicajaniuk approved these changes Sep 20, 2022

View reviewed changes

jessicajaniuk removed request for dylhunn and pkozlowski-opensource September 20, 2022 00:35

jessicajaniuk added action: cleanup The PR is in need of cleanup, either due to needing a rebase or in response to comments from reviews and removed action: review The PR is still awaiting reviews from at least one requested reviewer labels Sep 20, 2022

thePunderWoman removed the action: cleanup The PR is in need of cleanup, either due to needing a rebase or in response to comments from reviews label Nov 22, 2024

thePunderWoman added the state: blocked label Nov 22, 2024

pullapprove Bot requested review from alxhub, pkozlowski-opensource and thePunderWoman November 22, 2024 14:53

thePunderWoman removed their request for review April 2, 2025 12:35

pullapprove Bot requested a review from thePunderWoman April 2, 2025 12:35

thePunderWoman approved these changes Apr 2, 2025

View reviewed changes

crisbeto modified the milestones: Backlog, v21 Candidate Jun 4, 2025

pkozlowski-opensource removed request for alxhub and pkozlowski-opensource June 4, 2025 14:40

crisbeto marked this pull request as draft June 4, 2025 14:40

crisbeto force-pushed the 46815/injection-token-types branch from 4cfaeb9 to 911147a Compare September 17, 2025 15:16

JeanMeche force-pushed the 46815/injection-token-types branch 3 times, most recently from d513b9f to 875b4ad Compare February 7, 2026 18:38

JeanMeche added a commit to JeanMeche/components that referenced this pull request Feb 7, 2026

refactor(material/sidenav): set generic for the `MAT_DRAWER_CONTAINER…

59e7973

…` token cleanup related to angular/angular/pull/47461

JeanMeche added a commit to JeanMeche/components that referenced this pull request Feb 7, 2026

refactor(material/chips): set generic for the MAT_CHIP token

ef8cff8

cleanup related to angular/angular/pull/47461

JeanMeche added a commit to JeanMeche/components that referenced this pull request Feb 7, 2026

refactor(material/slider): set generic for the MAT_SLIDER token

7ce623c

cleanup related to angular/angular/pull/47461

JeanMeche mentioned this pull request Feb 7, 2026

Set generic on some InjectionToken. angular/components#32753

Merged

JeanMeche force-pushed the 46815/injection-token-types branch from 875b4ad to 3baae5c Compare February 7, 2026 19:09

JeanMeche added a commit to JeanMeche/components that referenced this pull request Feb 8, 2026

refactor(cdk/drag-drop): set generic for the CDK_DROP_LIST_GROUP token

317aa7d

cleanup related to angular/angular/pull/47461

JeanMeche added a commit to JeanMeche/components that referenced this pull request Feb 8, 2026

refactor(cdk/drag-drop): set generic for the CDK_DROP_LIST_GROUP token

58dbc11

cleanup related to angular/angular/pull/47461

angular-robot Bot closed this Apr 17, 2026

angular-automatic-lock-bot Bot locked and limited conversation to collaborators May 18, 2026

Uh oh!

Conversation

crisbeto commented Sep 16, 2022

Uh oh!

crisbeto commented Sep 16, 2022

Uh oh!

Uh oh!

Uh oh!

devversion Sep 16, 2022

Choose a reason for hiding this comment

Uh oh!

crisbeto Sep 16, 2022

Choose a reason for hiding this comment

Uh oh!

AndrewKushnir Sep 16, 2022

Choose a reason for hiding this comment

Uh oh!

crisbeto Sep 19, 2022

Choose a reason for hiding this comment

Uh oh!

JoostK Sep 19, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

devversion Sep 19, 2022

Choose a reason for hiding this comment

Uh oh!

JoostK Sep 19, 2022

Choose a reason for hiding this comment

Uh oh!

AndrewKushnir left a comment

Choose a reason for hiding this comment

Uh oh!

AndrewKushnir left a comment

Choose a reason for hiding this comment

Uh oh!

jessicajaniuk left a comment

Choose a reason for hiding this comment

Uh oh!

Harpush commented Mar 28, 2023

Uh oh!

crisbeto commented Mar 28, 2023

Uh oh!

thePunderWoman left a comment

Choose a reason for hiding this comment

Uh oh!

angular-robot Bot commented Apr 17, 2026

Uh oh!

angular-automatic-lock-bot Bot commented May 18, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

8 participants

JoostK Sep 19, 2022 •

edited

Loading