ci: add more owners for limited categories#38170
Closed
jelbourn wants to merge 1 commit into
Closed
Conversation
atscott
approved these changes
Jul 22, 2020
AndrewKushnir
approved these changes
Jul 22, 2020
AndrewKushnir
left a comment
AndrewKushnir
left a comment
Contributor
There was a problem hiding this comment.
LGTM, thanks @jelbourn 👍
I'm wondering if we can do similar thing for circular-dependencies group as well (request 3-4 and require 2 approvals)?
jelbourn
force-pushed
the
even-more-owners
branch
from
82962de to
fa8bf25
Compare
Contributor
Author
|
Comments addressed |
* Add alxhub, atscott, and AndrewKushnir to code owners * Add atscott & AndrewKushnir to public-api and size-tracking Follow-up to angular#37994
jelbourn
force-pushed
the
even-more-owners
branch
2 times, most recently
from
12541e3 to
043e608
Compare
mhevery
pushed a commit
that referenced
this pull request
Jul 28, 2020
Splaktar
pushed a commit
to angular-hispano/angular
that referenced
this pull request
Aug 8, 2020
* Add alxhub, atscott, and AndrewKushnir to code owners * Add atscott & AndrewKushnir to public-api and size-tracking Follow-up to angular#37994 PR Close angular#38170
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
profanis
pushed a commit
to profanis/angular
that referenced
this pull request
Sep 5, 2020
* Add alxhub, atscott, and AndrewKushnir to code owners * Add atscott & AndrewKushnir to public-api and size-tracking Follow-up to angular#37994 PR Close angular#38170
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
-1(all) to requesting four (still requiring three and two, respectively)Follow-up to #37994