Skip to content

docs(router): fix typo in "spotlight on pathmatch"#38039

Closed
dmbarreiro wants to merge 1 commit into
angular:masterfrom
dmbarreiro:fix_router_tutorial_typo
Closed

docs(router): fix typo in "spotlight on pathmatch"#38039
dmbarreiro wants to merge 1 commit into
angular:masterfrom
dmbarreiro:fix_router_tutorial_typo

Conversation

@dmbarreiro

@dmbarreiro dmbarreiro commented Jul 14, 2020 •
edited
Loading

Copy link
Copy Markdown
Contributor

https://angular.io/guide/router-tutorial-toh#pathmatch

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • CI related changes
  • Documentation content changes
  • angular.io application / infrastructure changes
  • Other... Please describe:

What is the current behavior?

Markdown code is shown instead of expected anchor tag link.

Issue Number: N/A

What is the new behavior?

The link should be properly redered.

Does this PR introduce a breaking change?

  • Yes
  • No

Other information

@googlebot

googlebot commented Jul 14, 2020

Copy link
Copy Markdown

We found a Contributor License Agreement for you (the sender of this pull request), but were unable to find agreements for all the commit author(s) or Co-authors. If you authored these, maybe you used a different email address in the git commits than was used to sign the CLA (login here to double check)? If these were authored by someone else, then they will need to sign a CLA as well, and confirm that they're okay with these being contributed to Google.
In order to pass this check, please resolve this problem and then comment @googlebot I fixed it.. If the bot doesn't comment, it means it doesn't think anything has changed.

ℹ️ Googlers: Go here for more info.

@pullapprove pullapprove Bot requested a review from atscott July 14, 2020 10:04
@googlebot

googlebot commented Jul 14, 2020

Copy link
Copy Markdown

CLAs look good, thanks!

ℹ️ Googlers: Go here for more info.

@atscott atscott added comp: docs target: patch This PR is targeted for the next patch release labels Jul 14, 2020
@ngbot ngbot Bot added this to the needsTriage milestone Jul 14, 2020
@atscott atscott added the action: merge The PR is ready for merge by the caretaker label Jul 14, 2020
@atscott atscott closed this in f01b033 Jul 14, 2020
atscott pushed a commit that referenced this pull request Jul 14, 2020
@dmbarreiro @atscott
docs(router): fix typo in "spotlight on pathmatch" (#38039)
d690eec 
https://angular.io/guide/router-tutorial-toh#pathmatch

PR Close #38039
@dmbarreiro dmbarreiro deleted the fix_router_tutorial_typo branch July 14, 2020 20:31
@angular-automatic-lock-bot

angular-automatic-lock-bot Bot commented Aug 14, 2020

Copy link
Copy Markdown

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot Bot locked and limited conversation to collaborators Aug 14, 2020
profanis pushed a commit to profanis/angular that referenced this pull request Sep 5, 2020
@dmbarreiro @profanis
docs(router): fix typo in "spotlight on pathmatch" (angular#38039)
1222a08 
https://angular.io/guide/router-tutorial-toh#pathmatch

PR Close angular#38039
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@atscott atscott atscott approved these changes

Assignees

No one assigned

Labels

action: merge The PR is ready for merge by the caretaker cla: yes target: patch This PR is targeted for the next patch release

Projects

None yet

Milestone

needsTriage

Development

Successfully merging this pull request may close these issues.

3 participants

@dmbarreiro @googlebot @atscott