docs(router): Fix typo in https://angular.io/guide/router#activated-route#38034
Closed
rnlee0054 wants to merge 1 commit into
Closed
docs(router): Fix typo in https://angular.io/guide/router#activated-route#38034rnlee0054 wants to merge 1 commit into
rnlee0054 wants to merge 1 commit into
Conversation
atscott
approved these changes
Jul 13, 2020
atscott
added
comp: docs
target: patch
Contributor
|
Hi @rnlee0054, thanks for the fix. Could you amend the commit message header to be "docs(router)..." to conform to our header requirements (and get the lint check to pass)? |
rnlee0054
changed the title
…oute In angular.io, it linked to the wrong part of the page. https://angular.io/guide/router#activated-route
Contributor
Author
|
Done. thanks ! |
atscott
pushed a commit
that referenced
this pull request
Jul 14, 2020
…oute (#38034) In angular.io, it linked to the wrong part of the page. https://angular.io/guide/router#activated-route PR Close #38034
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
profanis
pushed a commit
to profanis/angular
that referenced
this pull request
Sep 5, 2020
…oute (angular#38034) In angular.io, it linked to the wrong part of the page. https://angular.io/guide/router#activated-route PR Close angular#38034
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR Checklist
Please check if your PR fulfills the following requirements:
PR Type
What kind of change does this PR introduce?
What is the current behavior?
In angular.io, it linked to the wrong part of the page. https://angular.io/guide/router#activated-route
Issue Number: N/A
What is the new behavior?
It should now link to the right header.
Does this PR introduce a breaking change?
Other information