docs: fix typo in "Creating libraries" guide (by publishing...ensures --> publishing...ensures)#38032
Closed
gkalpak wants to merge 1 commit into
Closed
docs: fix typo in "Creating libraries" guide (by publishing...ensures --> publishing...ensures)#38032gkalpak wants to merge 1 commit into
by publishing...ensures --> publishing...ensures)#38032gkalpak wants to merge 1 commit into
Conversation
…s` --> `publishing...ensures`)
gkalpak
added
comp: docs
action: merge
|
You can preview a1c4746 at https://pr38032-a1c4746.ngbuilds.io/. |
kapunahelewong
approved these changes
Jul 14, 2020
Contributor
|
Hi @gkalpak, can we move forward with this PR or we need a review from Minko? Since this is a typo, I think Kapunahele's review should be enough? |
AndrewKushnir
approved these changes
Jul 15, 2020
AndrewKushnir
added
the
merge: caretaker note
Contributor
|
FYI, discussed with George: since this is a typo fix, current set of approvals is enough. Thank you. |
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
profanis
pushed a commit
to profanis/angular
that referenced
this pull request
Sep 5, 2020
…s` --> `publishing...ensures`) (angular#38032) PR Close angular#38032
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
☝️