feat(dev-infra): add bazel firefox browser with RBE compatibility#38029
Closed
devversion wants to merge 1 commit into
Closed
feat(dev-infra): add bazel firefox browser with RBE compatibility#38029devversion wants to merge 1 commit into
devversion wants to merge 1 commit into
Conversation
devversion
added
hotlist: components team
Adds Firefox as browser to `dev-infra/browsers` with RBE compatibility. The default Firefox browser is not compatible similar to the default Chromium version exposed by `rules_webtesting`. The Angular Components repository will use this browser target as it enables RBE support. Also it gives us more flexibility about the Firefox version we test against. The version provided by `rules_webtesting` is very old and most likely not frequently updated (based on past experience).
devversion
force-pushed
the
feat/dev-infra-firefox-version
branch
from
9c5ed5d to
9c80fe2
Compare
Contributor
|
@devversion It seems like something is broken but I don't think it was a change you made. I'm getting this error I tried this out with angular/angular's master branch and I'm getting the same error |
Contributor
|
I've noticed one small issue with the new bazel package that I think we can resolve here. Lets discuss tomorrow 👍 |
wagnermaciel
approved these changes
Jul 14, 2020
wagnermaciel
left a comment
wagnermaciel
left a comment
Contributor
There was a problem hiding this comment.
LGTM. As per our discussion I will handle the BUILD file issue in PR #38026
JiaLiPassion
approved these changes
Jul 14, 2020
JiaLiPassion
left a comment
JiaLiPassion
left a comment
Contributor
There was a problem hiding this comment.
LGTM for the zone.js part.
AndrewKushnir
pushed a commit
that referenced
this pull request
Jul 15, 2020
…8029) Adds Firefox as browser to `dev-infra/browsers` with RBE compatibility. The default Firefox browser is not compatible similar to the default Chromium version exposed by `rules_webtesting`. The Angular Components repository will use this browser target as it enables RBE support. Also it gives us more flexibility about the Firefox version we test against. The version provided by `rules_webtesting` is very old and most likely not frequently updated (based on past experience). PR Close #38029
devversion
added a commit
to devversion/material2
that referenced
this pull request
Jul 16, 2020
Updates our Firefox version that is used for Bazel unit tests to v78.0. Previously we were using v68. To update the Firefox version, we had to set up a custom Browser target with repositories as the version for Firefox is usually hard-coded in `rules_webtesting` and we cannot control that. See related change in the dev-infra package: angular/angular#38029.
devversion
added a commit
to devversion/material2
that referenced
this pull request
Jul 16, 2020
Updates our Firefox version that is used for Bazel unit tests to v78.0. Previously we were using v68. To update the Firefox version, we had to set up a custom Browser target with repositories as the version for Firefox is usually hard-coded in `rules_webtesting` and we cannot control that. See related change in the dev-infra package: angular/angular#38029.
devversion
added a commit
to devversion/material2
that referenced
this pull request
Jul 17, 2020
Updates our Firefox version that is used for Bazel unit tests to v78.0. Previously we were using v68. To update the Firefox version, we had to set up a custom Browser target with repositories as the version for Firefox is usually hard-coded in `rules_webtesting` and we cannot control that. See related change in the dev-infra package: angular/angular#38029.
andrewseguin
pushed a commit
to angular/components
that referenced
this pull request
Jul 17, 2020
Updates our Firefox version that is used for Bazel unit tests to v78.0. Previously we were using v68. To update the Firefox version, we had to set up a custom Browser target with repositories as the version for Firefox is usually hard-coded in `rules_webtesting` and we cannot control that. See related change in the dev-infra package: angular/angular#38029.
ngwattcos
pushed a commit
to ngwattcos/components
that referenced
this pull request
Jul 20, 2020
Updates our Firefox version that is used for Bazel unit tests to v78.0. Previously we were using v68. To update the Firefox version, we had to set up a custom Browser target with repositories as the version for Firefox is usually hard-coded in `rules_webtesting` and we cannot control that. See related change in the dev-infra package: angular/angular#38029.
trik
pushed a commit
to gnucoop/ajf
that referenced
this pull request
Aug 10, 2020
Updates our Firefox version that is used for Bazel unit tests to v78.0. Previously we were using v68. To update the Firefox version, we had to set up a custom Browser target with repositories as the version for Firefox is usually hard-coded in `rules_webtesting` and we cannot control that. See related change in the dev-infra package: angular/angular#38029.
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
profanis
pushed a commit
to profanis/angular
that referenced
this pull request
Sep 5, 2020
…gular#38029) Adds Firefox as browser to `dev-infra/browsers` with RBE compatibility. The default Firefox browser is not compatible similar to the default Chromium version exposed by `rules_webtesting`. The Angular Components repository will use this browser target as it enables RBE support. Also it gives us more flexibility about the Firefox version we test against. The version provided by `rules_webtesting` is very old and most likely not frequently updated (based on past experience). PR Close angular#38029
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds Firefox as browser to
dev-infra/browserswith RBEcompatibility. The default Firefox browser is not compatible similar to
the default Chromium version exposed by
rules_webtesting.The Angular Components repository will use this browser target as
it enables RBE support. Also it gives us more flexibility about
the Firefox version we test against. The version provided by
rules_webtestingis very old and most likely not frequentlyupdated (based on past experience).
Additionally, for a more structured
dev-infra/browsersfolder, chromiumand firefox specifics are stored in dedicated folders. This results in
unexpected diff for chromium, but there is no change other than it
being moved into a subfolder.
Note for reviewer that the webtesting rules require us to explicitly specify
dev-infra/browsers/chromium:chromiumwhen consuming the browsersas it picks up the browser name from the target name after the colon.