Skip to content

ci: add more owners for some categories #37994

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
jelbourn wants to merge 1 commit into from
Closed

ci: add more owners for some categories #37994

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 8 additions & 2 deletions .pullapprove.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1141,9 +1141,10 @@ groups:
])
reviewers:
users:
- alxhub
- IgorMinar
- alxhub
- jelbourn
- petebacondarwin
Comment thread
jelbourn marked this conversation as resolved.
Outdated
- pkozlowski-opensource
reviews:
request: -1 # request reviews from everyone
Expand All @@ -1164,9 +1165,10 @@ groups:
])
reviewers:
users:
- alxhub
- IgorMinar
- alxhub
- jelbourn
- petebacondarwin
Comment thread
jelbourn marked this conversation as resolved.
Outdated
- pkozlowski-opensource
reviews:
request: -1 # request reviews from everyone
Expand All @@ -1190,6 +1192,7 @@ groups:
- IgorMinar
- jelbourn
- josephperrott
- petebacondarwin
Comment thread
jelbourn marked this conversation as resolved.
Outdated
- pkozlowski-opensource


Expand All @@ -1211,6 +1214,9 @@ groups:
reviewers:
users:
- IgorMinar
- jelbourn
- josephperrott
- mhevery

@IgorMinar IgorMinar Jul 10, 2020

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's add also add:

reviews:
      request: -1   # request reviews from everyone
      required: 2   # require at least 2 approvals

This group is the root group in the repo, and it would make little sense if the rule for approving this group were more lenient than the requirements for the public-api or size-tracking groups.

@jelbourn jelbourn Jul 13, 2020 •
edited
Loading

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That seems a bit like overkill to me. The reason public-api approvers requires more people is because API decisions have a level of judgement involved in each change and warrant some discussion. This, by contrast, just seems like an accounting of who's responsible for this file which shouldn't be controversial.

@jenhsieh jenhsieh Jul 16, 2020

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's keep to the current policy and not add the additional requirement of 2 approvals. I trust our team not to add themselves or each other to code owners irresponsibly.



# ====================================================
Expand Down