Skip to content

ci: add more owners for some categories#37994

Closed
jelbourn wants to merge 1 commit into
angular:masterfrom
jelbourn:more-owners
Closed

ci: add more owners for some categories#37994
jelbourn wants to merge 1 commit into
angular:masterfrom
jelbourn:more-owners

Conversation

@jelbourn

@jelbourn jelbourn commented Jul 9, 2020

Copy link
Copy Markdown
Contributor
  • Add petebacondarwin to public-api, size-tracking, and
    -circular-dependencies
  • Add josephperrott and jelbourn to code-ownership

@jelbourn jelbourn added the target: patch This PR is targeted for the next patch release label Jul 9, 2020
@pullapprove pullapprove Bot requested a review from IgorMinar July 9, 2020 16:55
petebacondarwin
petebacondarwin approved these changes Jul 9, 2020
View reviewed changes

@petebacondarwin petebacondarwin left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lucky me!

IgorMinar
IgorMinar suggested changes Jul 10, 2020
View reviewed changes
Comment thread .pullapprove.yml Outdated

@IgorMinar IgorMinar Jul 10, 2020

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's add also add:

reviews:
      request: -1   # request reviews from everyone
      required: 2   # require at least 2 approvals

This group is the root group in the repo, and it would make little sense if the rule for approving this group were more lenient than the requirements for the public-api or size-tracking groups.

@jelbourn jelbourn Jul 13, 2020 •
edited
Loading

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That seems a bit like overkill to me. The reason public-api approvers requires more people is because API decisions have a level of judgement involved in each change and warrant some discussion. This, by contrast, just seems like an accounting of who's responsible for this file which shouldn't be controversial.

@jenhsieh jenhsieh Jul 16, 2020

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's keep to the current policy and not add the additional requirement of 2 approvals. I trust our team not to add themselves or each other to code owners irresponsibly.

Comment thread .pullapprove.yml Outdated
Comment thread .pullapprove.yml Outdated
Comment thread .pullapprove.yml Outdated
@jelbourn
ci: add more owners for some categories
a969a2d 
* Add petebacondarwin to public-api, size-tracking, and circular-dependencies
* Add mhevery, josephperrott, and jelbourn to code-ownership
@jelbourn jelbourn added the merge: caretaker note Alert the caretaker performing the merge to check the PR for an out of normal action needed or note label Jul 16, 2020
@ngbot ngbot Bot added the action: merge The PR is ready for merge by the caretaker label Jul 16, 2020
@ngbot

ngbot Bot commented Jul 16, 2020

Copy link
Copy Markdown

I see that you just added the PR action: merge label, but the following checks are still failing:
    failure status "pullapprove" is failing
    pending 2 pending code reviews

If you want your PR to be merged, it has to pass all the CI checks.

If you can't get the PR to a green state due to flakes or broken master, please try rebasing to master and/or restarting the CI job. If that fails and you believe that the issue is not due to your change, please contact the caretaker and ask for help.

@jelbourn

jelbourn commented Jul 16, 2020

Copy link
Copy Markdown
Contributor Author

Caretaker: this PR needs assistance because Igor is currently the only one who can approve changes to this code owners, which this PR fixes.

AndrewKushnir pushed a commit that referenced this pull request Jul 16, 2020
@jelbourn @AndrewKushnir
ci: add more owners for some categories (#37994)
06ac757 
* Add petebacondarwin to public-api, size-tracking, and circular-dependencies
* Add mhevery, josephperrott, and jelbourn to code-ownership

PR Close #37994
@jelbourn jelbourn mentioned this pull request Jul 22, 2020
Closed
jelbourn added a commit to jelbourn/angular that referenced this pull request Jul 28, 2020
@jelbourn
ci: add more owners for limited categories
043e608 
* Add alxhub, atscott, and AndrewKushnir to code owners
* Add atscott & AndrewKushnir to public-api and size-tracking

Follow-up to angular#37994
mhevery pushed a commit that referenced this pull request Jul 28, 2020
@jelbourn @mhevery
ci: add more owners for limited categories (#38170)
c27ba96 
* Add alxhub, atscott, and AndrewKushnir to code owners
* Add atscott & AndrewKushnir to public-api and size-tracking

Follow-up to #37994

PR Close #38170
mhevery pushed a commit that referenced this pull request Jul 28, 2020
@jelbourn @mhevery
ci: add more owners for limited categories (#38170)
5621452 
* Add alxhub, atscott, and AndrewKushnir to code owners
* Add atscott & AndrewKushnir to public-api and size-tracking

Follow-up to #37994

PR Close #38170
Splaktar pushed a commit to angular-hispano/angular that referenced this pull request Aug 8, 2020
@jelbourn @Splaktar
ci: add more owners for limited categories (angular#38170)
e91aa6d 
* Add alxhub, atscott, and AndrewKushnir to code owners
* Add atscott & AndrewKushnir to public-api and size-tracking

Follow-up to angular#37994

PR Close angular#38170
@angular-automatic-lock-bot

angular-automatic-lock-bot Bot commented Aug 16, 2020

Copy link
Copy Markdown

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot Bot locked and limited conversation to collaborators Aug 16, 2020
profanis pushed a commit to profanis/angular that referenced this pull request Sep 5, 2020
@jelbourn @profanis
ci: add more owners for some categories (angular#37994)
4130c0b 
* Add petebacondarwin to public-api, size-tracking, and circular-dependencies
* Add mhevery, josephperrott, and jelbourn to code-ownership

PR Close angular#37994
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@josephperrott josephperrott Awaiting requested review from josephperrott

3 more reviewers

@jenhsieh jenhsieh jenhsieh left review comments

@IgorMinar IgorMinar IgorMinar requested changes

@petebacondarwin petebacondarwin petebacondarwin approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

action: merge The PR is ready for merge by the caretaker cla: yes merge: caretaker note Alert the caretaker performing the merge to check the PR for an out of normal action needed or note target: patch This PR is targeted for the next patch release

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@jelbourn @petebacondarwin @IgorMinar @jenhsieh @googlebot