fix(compiler-cli): ensure file_system handles mixed Windows drives#37959
Closed
petebacondarwin wants to merge 5 commits into
Closed
fix(compiler-cli): ensure file_system handles mixed Windows drives#37959petebacondarwin wants to merge 5 commits into
petebacondarwin wants to merge 5 commits into
Conversation
petebacondarwin
added
type: bug/fix
action: review
gkalpak
approved these changes
Jul 8, 2020
gkalpak
left a comment
gkalpak
left a comment
Member
There was a problem hiding this comment.
Nice and clean! (I was afraid it would get more messy 😅)
Some minor suggestions; otherwise LGTM 🚀
Also, commit message typo: and AbsoluteFsPath --> an `AbsoluteFsPath`
gkalpak
added
the
action: cleanup
The `fs.relative()` method assumed that the file-system is a single tree, which is not the case in Windows, where you can have multiple drives, e.g. `C:`, `D:` etc. This commit changes `fs.relative()` so that it no longer forces the result to be a `PathSegment` and then flows that refactoring through the rest of the compiler-cli (and ngcc). The main difference is that now, in some cases, we needed to check whether the result is "rooted", i.e an `AbsoluteFsPath`, rather than a `PathSegment`, before using it. Fixes angular#36777
petebacondarwin
force-pushed
the
ngcc-windows-drive-paths
branch
from
7be6df8 to
b415f89
Compare
JoostK
approved these changes
Jul 8, 2020
petebacondarwin
added
action: presubmit
Member
|
Caretaker: this will need cl/320619026 in order to be synced successfully (manually run the sync tool from a client with this change). |
alxhub
added
the
merge: caretaker note
petebacondarwin
removed
the
action: presubmit
petebacondarwin
added
target: major
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
profanis
pushed a commit
to profanis/angular
that referenced
this pull request
Sep 5, 2020
…ngular#37959) The `fs.relative()` method assumed that the file-system is a single tree, which is not the case in Windows, where you can have multiple drives, e.g. `C:`, `D:` etc. This commit changes `fs.relative()` so that it no longer forces the result to be a `PathSegment` and then flows that refactoring through the rest of the compiler-cli (and ngcc). The main difference is that now, in some cases, we needed to check whether the result is "rooted", i.e an `AbsoluteFsPath`, rather than a `PathSegment`, before using it. Fixes angular#36777 PR Close angular#37959
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
fs.relative()method assumed that the file-system is a single tree,which is not the case in Windows, where you can have multiple drives,
e.g.
C:,D:etc.This commit changes
fs.relative()so that it no longer forces the resultto be a
PathSegmentand then flows that refactoring through the rest ofthe compiler-cli (and ngcc). The main difference is that in some cases
we needed to check whether the result is "rooted", i.e and AbsoluteFsPath,
rather than a
PathSegment, before using it.Fixes #36777