docs: break testing doc into multiple docs#37957
Closed
kapunahelewong wants to merge 1 commit into
Closed
Conversation
kapunahelewong
added
feature
pullapprove
Bot
requested review from
aikithoughts,
gkalpak and
pkozlowski-opensource
|
You can preview fff04e2 at https://pr37957-fff04e2.ngbuilds.io/. |
gkalpak
approved these changes
Jul 7, 2020
gkalpak
left a comment
gkalpak
left a comment
Member
There was a problem hiding this comment.
LGTM for fw-upgrade (with one minor comment) 👍
Reviewed-for: fw-upgrade
gkalpak
added
the
action: cleanup
kapunahelewong
force-pushed
the
testing-phase1
branch
from
fff04e2 to
f01ff6a
Compare
This commit breaks up the testing document into nine total documents, with each document focusing on an existing section of the current testing documentation. There are no content changes.
kapunahelewong
force-pushed
the
testing-phase1
branch
from
f01ff6a to
ca2700e
Compare
|
You can preview ca2700e at https://pr37957-ca2700e.ngbuilds.io/. |
kapunahelewong
added
the
target: patch
pkozlowski-opensource
approved these changes
Jul 8, 2020
aikithoughts
approved these changes
Jul 8, 2020
aikithoughts
left a comment
aikithoughts
left a comment
Contributor
There was a problem hiding this comment.
LGTM. Thank you for the excellent commit message!
Reviewed-for: global-docs-approvers
kapunahelewong
removed
the
action: cleanup
aikithoughts
approved these changes
Jul 8, 2020
jelbourn
approved these changes
Jul 8, 2020
jelbourn
left a comment
jelbourn
left a comment
Contributor
There was a problem hiding this comment.
LGTM, using global approvers for codeowners
Reviewed-for: global-approvers
jelbourn
added
action: merge
atscott
pushed a commit
that referenced
this pull request
Jul 8, 2020
This commit breaks up the testing document into nine total documents, with each document focusing on an existing section of the current testing documentation. There are no content changes. PR Close #37957
gkalpak
added a commit
to gkalpak/angular
that referenced
this pull request
Jul 14, 2020
In angular#37957, parts of the testing guide were broken out into separate guides. As part of that work, the `<live-example>` tags were also copied to the new guides. These `<live-example>` tags did not specify the targeted example project via the `name` attribute, thus they were implicitly targeting the example with the same name as the guide they were in. See the [Docs style guide][1] for more info. However, there is only one example project (`testing/`) and all `<live-example>` tags were supposed to target that. This worked fine on the `testing.md` guide, but it broke on other guides (which tried to target non-existing example projects based on their names). This commit fixes it by explicitly specifying which example is targeted by the `<live-example>` tags. It also removes the `embedded-style` attribute that has no effect. [1]: https://angular.io/guide/docs-style-guide#live-examples Fixes angular#38036
atscott
pushed a commit
that referenced
this pull request
Jul 14, 2020
In #37957, parts of the testing guide were broken out into separate guides. As part of that work, the `<live-example>` tags were also copied to the new guides. These `<live-example>` tags did not specify the targeted example project via the `name` attribute, thus they were implicitly targeting the example with the same name as the guide they were in. See the [Docs style guide][1] for more info. However, there is only one example project (`testing/`) and all `<live-example>` tags were supposed to target that. This worked fine on the `testing.md` guide, but it broke on other guides (which tried to target non-existing example projects based on their names). This commit fixes it by explicitly specifying which example is targeted by the `<live-example>` tags. It also removes the `embedded-style` attribute that has no effect. [1]: https://angular.io/guide/docs-style-guide#live-examples Fixes #38036 PR Close #38038
atscott
pushed a commit
that referenced
this pull request
Jul 14, 2020
In #37957, parts of the testing guide were broken out into separate guides. As part of that work, the `<live-example>` tags were also copied to the new guides. These `<live-example>` tags did not specify the targeted example project via the `name` attribute, thus they were implicitly targeting the example with the same name as the guide they were in. See the [Docs style guide][1] for more info. However, there is only one example project (`testing/`) and all `<live-example>` tags were supposed to target that. This worked fine on the `testing.md` guide, but it broke on other guides (which tried to target non-existing example projects based on their names). This commit fixes it by explicitly specifying which example is targeted by the `<live-example>` tags. It also removes the `embedded-style` attribute that has no effect. [1]: https://angular.io/guide/docs-style-guide#live-examples Fixes #38036 PR Close #38038
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
profanis
pushed a commit
to profanis/angular
that referenced
this pull request
Sep 5, 2020
This commit breaks up the testing document into nine total documents, with each document focusing on an existing section of the current testing documentation. There are no content changes. PR Close angular#37957
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This commit breaks up the testing document into nine total documents, with each document focusing on an existing section of the current testing documentation. There are no content changes. The only copy changes are those that reference other parts of the former testing guide. So, for example if a sentence previously referred to the section above but that section is now in a different doc the reference now goes to that document and the wording is changed appropriately.
This PR only breaks the document apart, and does not rewrite the content. The content is as close as possible to the original.
PR Checklist
Please check if your PR fulfills the following requirements:
PR Type
What kind of change does this PR introduce?
What is the current behavior?
Issue Number: N/A
What is the new behavior?
Now there are new documents where the original testing document used to be. The new documents are each one of the major sections from the original testing.
Does this PR introduce a breaking change?
Other information
https://pr37957-ca2700e.ngbuilds.io/guide/testing