docs: remove all references to Angular Console#37608
Conversation
|
The product still exists. I recommend we just rename it to NX console in our listing. |
|
I'm not actually certain whether or not NX console requires nodeJS to be installed. If it does, then this recommend doesn't save users any work and it should be removed. |
|
It looks like Node.js is required. Apparently there is another reference to Angular Console in the docs (#37609). Should I remove that as well and update this MR? |
|
@StephenFluin, my main consern is that "Nx Console" is no longer a standalone app; it is a VSCode extension. So, it is only useful for people using VSCode. (Plus it is a UI for the nx cli and I am not sure what this means for Angular CLI apps.) |
|
Removal everywhere sounds great to me. it cannot function in the original
way it was intended to in our documentation.
…On Tue, Jun 16, 2020, 7:30 AM George Kalpakas ***@***.***> wrote:
@StephenFluin <https://github.com/StephenFluin>, my main consern is that
"Nx Console" is no longer a standalone app; it is a VSCode extension. So,
it is only useful for people using VSCode. (Plus it is a UI for the nx cli
and I am not sure what this means for Angular CLI apps.)
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#37608 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AABIJQCQMOQG3LEUXKGCRSDRW56YZANCNFSM4N7UX55A>
.
|
|
I removed all the references I could find. Let me know if I need to reword anything, since English isn't my native language. |
|
It looks like the commit body isn't long enough, but I'm not sure what information I should add to reach that minimum requirement. |
|
A reference needs to be removed from the CLI Overview, |
|
@jbogarthyde I think I already removed that reference? Or did I miss something else on that page? |
There was a problem hiding this comment.
Thanks, that looks like all the references I know about.
BTW, this is not actually (docs-infra) -- it is just doc content. You can use the second line of the commit message to add a long-winded description, up to the required 100 characters.
Perhaps:
"docs: remove references to Angular Console
Angular Console has been renamed and the links no longer work. It has been decided to remove references to this third-party tool from the AIO documentation."
(Note the blank link between the short and long part of the commit message.)
Angular Console has been renamed and links no longer work. It has been decided to remove references to this third-party tool from the AIO documentation. Closes #37604
|
@jbogarthyde I updated the commit subject line and body according to your message. Should be ok now! |
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Angular Console has been renamed and links no longer work. It has been decided to remove references to this third-party tool from the AIO documentation. Closes angular#37604 PR Close angular#37608
Angular Console has been renamed and links no longer work. It has been decided to remove references to this third-party tool from the AIO documentation.
PR Checklist
Please check if your PR fulfills the following requirements:
PR Type
What kind of change does this PR introduce?
What is the current behavior?
Issue Number: #37604
What is the new behavior?
Does this PR introduce a breaking change?
Other information