Skip to content

docs: remove all references to Angular Console#37608

Closed
Windvis wants to merge 1 commit into
angular:masterfrom
Windvis:docs/remove-angular-console-reference
Closed

docs: remove all references to Angular Console#37608
Windvis wants to merge 1 commit into
angular:masterfrom
Windvis:docs/remove-angular-console-reference

Conversation

@Windvis

@Windvis Windvis commented Jun 16, 2020

Copy link
Copy Markdown
Contributor

Angular Console has been renamed and links no longer work. It has been decided to remove references to this third-party tool from the AIO documentation.

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • CI related changes
  • Documentation content changes
  • angular.io application / infrastructure changes
  • Other... Please describe:

What is the current behavior?

Issue Number: #37604

What is the new behavior?

Does this PR introduce a breaking change?

  • Yes
  • No

Other information

@pullapprove pullapprove Bot requested a review from StephenFluin June 16, 2020 14:02
@StephenFluin

Copy link
Copy Markdown
Contributor

The product still exists. I recommend we just rename it to NX console in our listing.

@StephenFluin

Copy link
Copy Markdown
Contributor

I'm not actually certain whether or not NX console requires nodeJS to be installed. If it does, then this recommend doesn't save users any work and it should be removed.

@Windvis

Windvis commented Jun 16, 2020

Copy link
Copy Markdown
Contributor Author

It looks like Node.js is required.

Apparently there is another reference to Angular Console in the docs (#37609). Should I remove that as well and update this MR?

@gkalpak

gkalpak commented Jun 16, 2020

Copy link
Copy Markdown
Member

@StephenFluin, my main consern is that "Nx Console" is no longer a standalone app; it is a VSCode extension. So, it is only useful for people using VSCode. (Plus it is a UI for the nx cli and I am not sure what this means for Angular CLI apps.)

@StephenFluin

StephenFluin commented Jun 16, 2020 via email

Copy link
Copy Markdown
Contributor

@pullapprove pullapprove Bot requested a review from clydin June 16, 2020 14:46
@Windvis Windvis changed the title docs(docs-infra): remove a reference to Angular Console docs(docs-infra): remove all references to Angular Console Jun 16, 2020
@Windvis

Windvis commented Jun 16, 2020

Copy link
Copy Markdown
Contributor Author

I removed all the references I could find. Let me know if I need to reword anything, since English isn't my native language.

@ngbot ngbot Bot added this to the needsTriage milestone Jun 16, 2020
@Windvis

Windvis commented Jun 16, 2020

Copy link
Copy Markdown
Contributor Author

It looks like the commit body isn't long enough, but I'm not sure what information I should add to reach that minimum requirement.

@jbogarthyde

Copy link
Copy Markdown
Contributor

A reference needs to be removed from the CLI Overview, aio/content/cli/index.md -- see #37613

@Windvis

Windvis commented Jun 17, 2020

Copy link
Copy Markdown
Contributor Author

@jbogarthyde I think I already removed that reference? Or did I miss something else on that page?

@jbogarthyde jbogarthyde left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, that looks like all the references I know about.
BTW, this is not actually (docs-infra) -- it is just doc content. You can use the second line of the commit message to add a long-winded description, up to the required 100 characters.
Perhaps:
"docs: remove references to Angular Console

Angular Console has been renamed and the links no longer work. It has been decided to remove references to this third-party tool from the AIO documentation."

(Note the blank link between the short and long part of the commit message.)

Angular Console has been renamed and links no longer work. It has been decided to remove references to this third-party tool from the AIO documentation.

Closes #37604
@Windvis

Windvis commented Jun 18, 2020

Copy link
Copy Markdown
Contributor Author

@jbogarthyde I updated the commit subject line and body according to your message. Should be ok now!

@Windvis Windvis changed the title docs(docs-infra): remove all references to Angular Console docs: remove all references to Angular Console Jun 18, 2020
@pkozlowski-opensource pkozlowski-opensource added action: merge The PR is ready for merge by the caretaker target: patch This PR is targeted for the next patch release labels Jul 15, 2020
AndrewKushnir pushed a commit that referenced this pull request Jul 15, 2020
Angular Console has been renamed and links no longer work. It has been decided to remove references to this third-party tool from the AIO documentation.

Closes #37604

PR Close #37608
@angular-automatic-lock-bot

Copy link
Copy Markdown

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot Bot locked and limited conversation to collaborators Aug 15, 2020
profanis pushed a commit to profanis/angular that referenced this pull request Sep 5, 2020
Angular Console has been renamed and links no longer work. It has been decided to remove references to this third-party tool from the AIO documentation.

Closes angular#37604

PR Close angular#37608
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

action: merge The PR is ready for merge by the caretaker cla: yes target: patch This PR is targeted for the next patch release

Projects

None yet

Development

Successfully merging this pull request may close these issues.

8 participants