feat(router): add new initialNavigation options to replace legacy by CaerusKaru · Pull Request #37480 · angular/angular

CaerusKaru · 2020-06-07T23:13:58Z

As of Angular v4, four of the options for
ExtraOptions#initialNavigation have been deprecated. We intend
to remove them in v11. The final state for these options is:
enabledBlocking, enabledNonBlocking, and disabled. We plan
to remove and deprecate the remaining option in the next two
major releases.

New options:

enabledNonBlocking: same as legacy_enabled
enabledBlocking: same as enabled

BREAKING CHANGE:

The initialNavigation property for the options in
RouterModule.forRoot no longer supports legacy_disabled,
legacy_enabled, true, or false as valid values.
legacy_enabled (the old default) is instead enabledNonBlocking
enabled is deprecated as a valid value for the
RouterModule.forRoot initialNavigation option. enabledBlocking
has been introduced to replace it

PR Checklist

Please check if your PR fulfills the following requirements:

The commit message follows our guidelines: https://github.com/angular/angular/blob/master/CONTRIBUTING.md#commit
Tests for the changes have been added (for bug fixes / features)
Docs have been added / updated (for bug fixes / features)

PR Type

What kind of change does this PR introduce?

Bugfix
Feature
Code style update (formatting, local variables)
Refactoring (no functional changes, no api changes)
Build related changes
CI related changes
Documentation content changes
angular.io application / infrastructure changes
Other... Please describe:

What is the current behavior?

Issue Number: N/A

What is the new behavior?

Does this PR introduce a breaking change?

Yes
No

Other information

jelbourn

If there any deprecation documentation or similar we can link to in the commit message here?

jelbourn · 2020-06-23T20:31:48Z

I have learned since the last time I looked at this that there's a deprecation guide that outlines deprecations and what people should do about them. Should the changes here be included in there?

CaerusKaru · 2020-06-24T06:03:01Z

@jelbourn Since this PR does not actually deprecate/remove (and is outside a major version), I don’t think now is the time to add it. These options can be used independent of a deprecation plan. The deprecation guide update is captured in #33128, which was bumped from v10 to v11 and will land when we open up the v11 release train.

jelbourn

LGTM

Reviewed-for: public-api

mary-poppins · 2020-10-10T04:37:00Z

You can preview 424336c at https://pr37480-424336c.ngbuilds.io/.

mary-poppins · 2020-10-10T05:04:12Z

You can preview 78627e3 at https://pr37480-78627e3.ngbuilds.io/.

petebacondarwin

Reviewed-for: public-api

Minor docs suggestions.

AndrewKushnir

Thanks for the changes @CaerusKaru 👍

I've just left a couple comments, but all of them are minor.

Reviewed-for: public-api

AndrewKushnir

Adding a review from size tracking group...

Reviewed-for: size-tracking

As of Angular v4, four of the options for `ExtraOptions#initialNavigation` have been deprecated. We intend to remove them in v11. The final state for these options is: `enabledBlocking`, `enabledNonBlocking`, and `disabled`. We plan to remove and deprecate the remaining option in the next two major releases. New options: - `enabledNonBlocking`: same as legacy_enabled - `enabledBlocking`: same as enabled BREAKING CHANGE: * The `initialNavigation` property for the options in `RouterModule.forRoot` no longer supports `legacy_disabled`, `legacy_enabled`, `true`, or `false` as valid values. `legacy_enabled` (the old default) is instead `enabledNonBlocking` * `enabled` is deprecated as a valid value for the `RouterModule.forRoot` `initialNavigation` option. `enabledBlocking` has been introduced to replace it

mary-poppins · 2020-10-12T21:05:22Z

You can preview 7e77995 at https://pr37480-7e77995.ngbuilds.io/.

atscott

reviewed-for: size-tracking

atscott · 2020-10-13T16:45:38Z

presubmit (this will require a g3 patch, see cl/336894045)

angular-automatic-lock-bot · 2020-11-14T16:23:25Z

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

_{This action has been performed automatically by a bot.}

googlebot added the cla: yes label Jun 7, 2020

pullapprove Bot requested review from IgorMinar, alxhub, atscott, jelbourn and pkozlowski-opensource June 7, 2020 23:14

CaerusKaru force-pushed the adam/r branch 4 times, most recently from e338c5e to da67485 Compare June 7, 2020 23:31

atscott added the area: router label Jun 8, 2020

ngbot Bot added this to the needsTriage milestone Jun 8, 2020

CaerusKaru added action: review The PR is still awaiting reviews from at least one requested reviewer target: major This PR is targeted for the next major release labels Jun 9, 2020

atscott approved these changes Jun 10, 2020

View reviewed changes

jelbourn reviewed Jun 18, 2020

View reviewed changes

Comment thread packages/router/src/router_module.ts Outdated

Comment thread packages/router/src/router_module.ts Outdated

pullapprove Bot requested a review from jelbourn June 18, 2020 00:02

CaerusKaru force-pushed the adam/r branch 3 times, most recently from dfb9df0 to ca4ed7c Compare June 20, 2020 20:49

jelbourn approved these changes Jun 24, 2020

View reviewed changes

CaerusKaru force-pushed the adam/r branch 2 times, most recently from c72b4cb to 328decd Compare June 27, 2020 05:44

atscott mentioned this pull request Jul 9, 2020

queryParamMap emits outside outside any navigation #28504

Closed

CaerusKaru force-pushed the adam/r branch 2 times, most recently from 5595b1d to a061ab9 Compare July 15, 2020 04:32

atscott reviewed Jul 16, 2020

View reviewed changes

Comment thread packages/router/src/router_module.ts Outdated

atscott added the aio: preview label Jul 16, 2020

CaerusKaru removed request for AndrewKushnir and IgorMinar October 10, 2020 04:23

pullapprove Bot requested review from AndrewKushnir, IgorMinar and alxhub October 10, 2020 04:24

CaerusKaru force-pushed the adam/r branch from a63647f to 424336c Compare October 10, 2020 04:26

CaerusKaru force-pushed the adam/r branch from 424336c to 78627e3 Compare October 10, 2020 04:55

petebacondarwin approved these changes Oct 12, 2020

View reviewed changes

Comment thread packages/router/src/router_module.ts Outdated

pullapprove Bot requested a review from atscott October 12, 2020 16:45

AndrewKushnir approved these changes Oct 12, 2020

View reviewed changes

Comment thread packages/router/src/router_module.ts Outdated

Comment thread packages/router/src/router_module.ts Outdated

Comment thread packages/router/test/bootstrap.spec.ts Outdated

pullapprove Bot requested a review from AndrewKushnir October 12, 2020 17:01

AndrewKushnir approved these changes Oct 12, 2020

View reviewed changes

pullapprove Bot requested a review from jelbourn October 12, 2020 17:02

CaerusKaru force-pushed the adam/r branch from 78627e3 to 7e77995 Compare October 12, 2020 20:54

atscott approved these changes Oct 13, 2020

View reviewed changes

pullapprove Bot requested a review from atscott October 13, 2020 16:28

atscott approved these changes Oct 13, 2020

View reviewed changes

atscott added action: merge The PR is ready for merge by the caretaker and removed action: review The PR is still awaiting reviews from at least one requested reviewer labels Oct 13, 2020

atscott removed request for IgorMinar, alxhub and jelbourn October 14, 2020 16:43

atscott closed this in c4becca Oct 14, 2020

angular-automatic-lock-bot Bot locked and limited conversation to collaborators Nov 14, 2020

Conversation

CaerusKaru commented Jun 7, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

PR Checklist

PR Type

What is the current behavior?

What is the new behavior?

Does this PR introduce a breaking change?

Other information

Uh oh!

jelbourn left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

jelbourn commented Jun 23, 2020

Uh oh!

CaerusKaru commented Jun 24, 2020

Uh oh!

jelbourn left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

mary-poppins commented Oct 10, 2020

Uh oh!

mary-poppins commented Oct 10, 2020

Uh oh!

petebacondarwin left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

AndrewKushnir left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

AndrewKushnir left a comment

Choose a reason for hiding this comment

Uh oh!

mary-poppins commented Oct 12, 2020

Uh oh!

atscott left a comment

Choose a reason for hiding this comment

Uh oh!

atscott commented Oct 13, 2020

Uh oh!

angular-automatic-lock-bot Bot commented Nov 14, 2020

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

7 participants

CaerusKaru commented Jun 7, 2020 •

edited

Loading